Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2833048lqp; Mon, 25 Mar 2024 10:25:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZAuPPyGA0NQg0CVIUg6R/svT2uybeyRub+ALbYj6DOfxvGKFJcswKRsk0LgfnqAI+TVO/3EYaswoeC7eZfoOXDOMBlS0OqsmgwVtAqg== X-Google-Smtp-Source: AGHT+IE0Hd8AHSOlmdKz8dGYl9+5xr3015cJojpH9f+mt79HQ/q/6HNOrHsg5vEYPa5GuxF8kKsG X-Received: by 2002:ac2:5b43:0:b0:513:30fb:d64 with SMTP id i3-20020ac25b43000000b0051330fb0d64mr5867769lfp.44.1711387544890; Mon, 25 Mar 2024 10:25:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711387544; cv=pass; d=google.com; s=arc-20160816; b=QqufwdgQ8UVbIVjnV5Ci3Zvr/Bw5eyfGqmv0IbWoBVG6+RtF+IlDKRHF4eOTgIWTgj /+4E5YFOVgFjO2y3RoAYEnd8ixTxUhY9HNU23c1U3SW7eTdKJADi5IPyTzZFarwgMhWg GT7Ml7fe7pD38/qUj8KaunXK3W6qJ+idBzYE6Qkpm1ORD5GcM/d5cNHMDUK0rV6gyeKo qISIpBY/okRgalgsxXcj+3NmTADiEX7QgCZZKWX0S7JHGW7A4I8MlO14ARQybFriKrkS gijm2x9VlPYcIX5Cua510jUm9aRUcZ6mKEJ5W1rtTYVh7RVX2GhzOgWy5VDtxQEWpbjX V9MA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=GBcH1gHlUXmRafory3kjw/LZOHwna/s3jBusQjwBPGg=; fh=RKIHtCGkswGQQIUvsKd2SIfzVEkNXHD6N3m6XHDQILQ=; b=IEYGEJeFcPZleh0RvK+m/BSSwFug9DJBk9JQhgwToWzjGo/qg/Z5bK6AlIasEdQzqW Mrv6wUHdKuR2iUrzVaH7GiZZPn1j7rwf1+81IuhgjDW7/Alucbnln4uZkqRwTdOQYe0Q 6iGOJeeh6xMJDzITP3xCHnvTYrmwfqgoYkP/fDyMV6MX1u/MZcziUFCHaZZduLUidPIP gQhoel/8j57yqwRsQAWeis20s2AkKYUK0IljGBIUS4sBk369XHs0tOsyOCD21ZmSHHfQ IL9HBqvaJwS6hvW+0LF+AaYwblSHH8mnrXbOjq9+uZsqjtQ1MV5CWu1SHMJRXW6yTvhV L3ag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fX19eYhQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5214-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u18-20020a170906125200b00a46a922ddebsi2595584eja.642.2024.03.25.10.25.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 10:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5214-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fX19eYhQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5214-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 625AF1F64821 for ; Mon, 25 Mar 2024 17:22:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F74286AD8; Mon, 25 Mar 2024 16:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fX19eYhQ" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF37C6FE19 for ; Mon, 25 Mar 2024 16:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711382836; cv=none; b=CbccTYsIV5+BUcuKru4i5eoiyVBnppiuwKhddCH8a5nZ3uq9a7wf2WLNGTS1oAbkn4swb1VXI/7wVVLmrqeqbxG8ayd5dUcsfO1fbzQsIaNyh4LLmeVL3b+5c62gDAw9arZPBu0K8+ANRDDqAT7YsTYf1A7wsk4JcN2ldC4QSfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711382836; c=relaxed/simple; bh=GBcH1gHlUXmRafory3kjw/LZOHwna/s3jBusQjwBPGg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ZKdgR7tar5aqSfbw2qQAQ5bk85bAJS3c4/bme4NJYO6VC2c02W8h5K6W4Ty7vX90Vu68TglhIhXIPeFmsYL0lNFSyzr7tx4B3CSGfLTQCzu6bFpa1bzDlfwgg5FhjxCHfz+zlp5YUOcKqCNO/DngDBmwKMp1KrKzdeRhm676kWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fX19eYhQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A2EBC433C7; Mon, 25 Mar 2024 16:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711382835; bh=GBcH1gHlUXmRafory3kjw/LZOHwna/s3jBusQjwBPGg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fX19eYhQgJktjayIX3mJip7DwSBl98YGD2bR9Bt54PObSGgN5OY9V1uRP2tsITu2k MLrHyTXusTolZ3InIDkyA81Ww3OFtXtyp/rDojqcpvnSeIG7LVrvhVs0IbtHCkIHpc cTebwpRp7OnxSSPrcnsap1ylUIlGET9keVSBeOrqinn1na660HTS3JcTnhn+ek70PT rIGTkOKCXUNkp8v/Kmhb4FZfwEi4xMF4dpEKKHO/R+67PLSmjU/MnKhZIDp2rjLHPj vigMdenV5ly/ja+MPqVEnGOVJacwLKmoj2ST57yPPw2qK4G9O4e2uhj8D3jjkVLHDt iKqozuauIdIpQ== Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id ADB7011A18A9; Mon, 25 Mar 2024 17:07:12 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , linux-wireless@vger.kernel.org Cc: Johannes Berg , Miriam Rachel Korenblit Subject: Re: [PATCH] wifi: mac80211: use kvcalloc() for codel vars In-Reply-To: <20240325150509.9195643699e4.I1b94b17abc809491080d6312f31ce6b5decdd446@changeid> References: <20240325150509.9195643699e4.I1b94b17abc809491080d6312f31ce6b5decdd446@changeid> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 25 Mar 2024 17:07:12 +0100 Message-ID: <87y1a6b8i7.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Johannes Berg writes: > From: Johannes Berg > > This is a big array, but it's only used by software and > need not be contiguous in memory. Use kvcalloc() since > it's so big (order 5 allocation). > > Reviewed-by: Miriam Rachel Korenblit > Signed-off-by: Johannes Berg Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen