Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2857822lqp; Mon, 25 Mar 2024 11:10:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUJGbYeU1l8t0N6nFhmlf1S62YtPLtEHlp0FY0+RG2KA7P7HSbcRtmFF9U98fJk4R4vWN/hvgnPirvJeqrsqQf9G9FOJefPjpBrTKiO8w== X-Google-Smtp-Source: AGHT+IFPFREL4lO7qBGWOv63Evyv/Yj6//oVUaPO3XgTNfxPDgMdjfbSF4TzvcQKCApfOm19nCbM X-Received: by 2002:a50:9ee2:0:b0:56b:df29:43bd with SMTP id a89-20020a509ee2000000b0056bdf2943bdmr5202360edf.12.1711390232642; Mon, 25 Mar 2024 11:10:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711390232; cv=pass; d=google.com; s=arc-20160816; b=RnkfhdZw6mBbbfUwISmgqjSk9hjBnyE8iAl4nwHIunMKUUZvzDNjOYLbhAwkuV4XsY DdeVh9//fGg9aSuefm1arXnyIYdQW6YV3WlLt+IGxDhs6U0z2Ymc9XOU0fOx3jVOzBRB AGMilQE1WLK9O82Iq5zU3V/C7vTUe2s5KOWGcHLws7e+jp33gX/K4Nn5zFgRnyzQwcUt Y2DHsGmcP0FrxELw46OBNfdlrHnmvcin3VyG33PptrWrSNXFBz4XN0VH/0bI4xuPAejQ qZ8QWqGde40eYXFSDvmBQ1/ly/odeY7FNYmzFImO5VJfnHyc3KaYyS72plZvG8lrKcf8 9eJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:to :from:subject:message-id:dkim-signature; bh=nnKY1T08A15M6+1Z34Dh4uInNkexLpDJIf7Y4hljiKU=; fh=UexzAyO2q4tnyZqrDvWt+Dg0HsA1dlt7CRtAva/Lvoc=; b=IVaecfYqF4t+0/xeuPd1+coAIt1VkVO5rvXfnFV/kY7s+EOshl6V0Ixi1mlov7ssNB 8hQxHyWXTJm8ORzD1Yqmtxd+ab4aL9D+10taevWOY6jKLyrYRYcp5SRsbDz/fE2n8TYL 6krHian2DP0CAL8YZlq477SD2jA0meFYAXGeDBVQj4lg/bOnooI/u7Lf58nuSzkyJspc 4fIrJIs+hwJsKbXPcgAv+Vnrdyr8XCN7D6S1igjwKeA4fOyAdqNDOVM0UGjqaXXorOMR E3K2Mrbz1EksmS+MgnuC7evVSEzQBvRsuTF3UmfvV7tMwG9av8OT3e6v3qnPGhRnsYK9 IA0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=M9PQwdDY; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5226-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id g8-20020a056402428800b0056bf290890bsi2655195edc.165.2024.03.25.11.10.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 11:10:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=M9PQwdDY; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-5226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5226-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8FF091F374F4 for ; Mon, 25 Mar 2024 18:09:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4028737145; Mon, 25 Mar 2024 17:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="M9PQwdDY" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90ABD50272 for ; Mon, 25 Mar 2024 17:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711387837; cv=none; b=HlW637Dfm//NPcI0wabDpQm2a8Plhettjma5QK4U0Hl2B4sLUwMur582/C9zbHj/of0XeqVhLCMjArwJs/12tTv3eCdV+JXZY0OEhXAFuZLAv+x1RBBWn4OMViONcz3i+B9VI2yfYFAnEscBDvtcbIG80cxZ9mebfgF5LEW4Nfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711387837; c=relaxed/simple; bh=XN6jSiwUYPrnwlVKoMqbblGFuCTk19zWzlzhzTpPRj0=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JI9CT37lCS8zPbMpwpbUrYHMuW6ZozRiA6/X8TIS6dlELcXcthXkpPKWXq68KDc4gRQl1cv5srEgJiJMlZqRmAGaWlEiLsiqAKd7eCmIziTMFv2SVvyikJFbZB/RLpRJjknmKLcF5NAOACm0iGAEpmChR681Vj2Iex+ADaB/MyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=M9PQwdDY; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=nnKY1T08A15M6+1Z34Dh4uInNkexLpDJIf7Y4hljiKU=; t=1711387835; x=1712597435; b=M9PQwdDYn0M447Upu3Frfy0DREuvBtfOPwXD6HeNY8ZC7SI U5u2QX0h5C0dg3Fyqnzd6NM3llRbmMEd0tNB+QzBk6hHq5HdprOYqDoMNJjLgmEHp9cp8bz3pDMAf +tHO4DKy0H+ESxT+DyiPFDUOqvaP9Wyv6ir9EDEdHn0Hb21n6YV6sNoobawyHBqfW0WJIPdaNL5lM tkcCD3PFGAnTV9GjbJWE/snEp3ZjXdRzQmaZUoNSG5/Bl9uR/bsROYVh4Kho5GDhVqhIGTOTAty2Q WMxUs4TBjWvL+mLBafI6aHhsJb18yiajvns7pZYqoH9zXijZztwcSRT3jp/EcSTA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1roo9Z-0000000DzFW-0yRT; Mon, 25 Mar 2024 18:30:33 +0100 Message-ID: <449f6afbc20c57f704dbeabc3a8eac8fec676405.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: mac80211: Ensure links are cleaned up when driver fails. From: Johannes Berg To: Ben Greear , linux-wireless Date: Mon, 25 Mar 2024 18:30:32 +0100 In-Reply-To: <5fe480c4-fa39-1d29-a5e9-ba2447b08dd2@candelatech.com> References: <20231111001023.1335122-1-greearb@candelatech.com> <5fe480c4-fa39-1d29-a5e9-ba2447b08dd2@candelatech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Mon, 2024-03-25 at 09:10 -0700, Ben Greear wrote: > On 11/10/23 16:10, greearb@candelatech.com wrote: > > From: Ben Greear > >=20 > > On cleanup paths, links need to be deleted even if the driver fails > > to do so. Add a flag to cause driver errors to be ignored in > > appropriate cases. > >=20 > > This appears to fix some kernel warnings and crashes. >=20 > Hello Johannes, >=20 > Any interest in this patch? Well, you threw a bunch of unrelated stuff into it, and didn't even really explain why it's needed ... so not really? johannes