Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2858733lqp; Mon, 25 Mar 2024 11:12:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWxDjc+98sbidXfwMydr4YRsNWLdjyzPj/3dBFPkL2dtwqxOhDDp2mWwRpUXQjEEBGKxtCh0nsE6PRVnGDDgv0dYX0pXnCjLKAWtCBWLg== X-Google-Smtp-Source: AGHT+IHNKgOOWXdUIiUiox4gvsv9i73/am9FGfoQY4dusifrNKcvi3j8Sd1J0ATOWU3HsSA0ClXV X-Received: by 2002:a05:6a21:182:b0:1a3:69ef:7432 with SMTP id le2-20020a056a21018200b001a369ef7432mr10911773pzb.43.1711390320673; Mon, 25 Mar 2024 11:12:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711390320; cv=pass; d=google.com; s=arc-20160816; b=FB0KX8LOabDWstjwDRrghQRlK9G3VkN8EELleFD2IxEzibr1jtUx5qLnvIbPBTi30w +DwJiq2wSoN73oJox4XIEiO6RCNE5W93E6r4ajrQqRneDqwy0np3QVDcVl0Ha4KI86U6 rCnbwlv4kPR9yipyUGSyflgoa3lpBQ3nWaEes7ZPxymE7Ixm96P3Gv3aV0lsuZM/I7Fl nU2ILiUIl4r0UqxKpMoUWZipTojWxoH0vNP+DUt2RZ5KDnkVpJoaBI5EbJSWg5HUs9i4 MhTqLUB7rwzs+myLHRyfuhi4FZ+0PNn8CF+vlSCoO0LArTPZajlRRc8/kwf/EenchyO0 xvXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=O7+Kmjo9wPw3zoVAPIJnf0wznNuakqD4ryFI+lZaNrg=; fh=X2ZC6psv4/zBHH0WR9oux/AjIXf+J28PNfx273zG39c=; b=ySSv12pTOLgZhC/caJoHu7B7wU88rArAxV59bGwu8qmTyy3AobkUXRNAupQD2on6tx uWoERXfR7Fexqc3FqOBP1xsGj+lHW2ZaiHrfIYilUVdJgorrLDQZpllAB/X9LpvJdfmk u0+lnfqrRd41XedYo6XY7UCnZtwtYinGENHIYCXRdV28t6fHrHtrIMlQ+f17+Jjg3cvV NM6HLw30H7oF1l8v0XoYYL91si7FzZ3E661sTeroaKhn0lxYkJ3gE8u/MAh/n8NQgipN s9x7xCI3UQhAc35Ku/3Ge4agIHmqmTVKJgmGTK5Sp0xTqh6kZmzR75MiygRimLQ72++N h83g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eM49x+yJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e12-20020aa7824c000000b006ea44a301e8si5559494pfn.334.2024.03.25.11.12.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 11:12:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eM49x+yJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6B4062C74DF for ; Mon, 25 Mar 2024 18:02:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 871B614A8E; Mon, 25 Mar 2024 17:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eM49x+yJ" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F8AFEEA8 for ; Mon, 25 Mar 2024 17:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711387361; cv=none; b=odNVu6mv0tgCngkdYftfCWaP8dmo69p3FMjbZ8Aq6ach1ED5bRL6BTttnz7YFooG9U95V2Mp5V48vEsSPBNBxlLjMmvwv1cZb3xwoV4ljT8XvTTpuageJj0VeyoBGRoWygkNGxuGOE6YCeBSnSNkmigtTecSyeedL+MH/+ViLZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711387361; c=relaxed/simple; bh=JZTxDP0SzyHpcG7qdAUA28Ye/YlJBVeBvrW2Vf5JUEI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=iU+02Gs9vyhAElMS9Bpel6polJK4oPunADdDvq2+yukeOwVkHh371VJgXVsv63wsuUsdEiGELjaTag37dxmXL1DN/j58exEfrtipHHs5hT+6d7uEUyUo2T0tdYGnskApe65jn3R2tNk26ICALsUd8IEAPCJyXxTpgGkZjmIREYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eM49x+yJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B920C433F1; Mon, 25 Mar 2024 17:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711387360; bh=JZTxDP0SzyHpcG7qdAUA28Ye/YlJBVeBvrW2Vf5JUEI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=eM49x+yJAaeZLs2lFuNZ0Ivs6Fdb5fEBl0rn0sikquEQ1zAilfaPUjiHNEnwx4pvp qsADHPiZgR5KAfzvYS3x86OaMbTMG8JNeJ42keQAZU2a77Frb6pf1Z0avXXseNsjA+ wLqC3+J0FdWwoBmdyPlsRkV6bwLwzLnVP2q1Evx2Y2QZ211LHaSf7987p3AaWAtPMt +Pyk82EiGEgYF1jjJ+qqCpt+1g+219d/egHHzyb0mMAhj5HRxGhphqtmCROVV8MK82 PMZHVUemEinJtR+Ciu5ScvFrCxbN9pjlGQZaSUtd87lYxzfv8qWxg4RmwoGl/jvdcj +wlQohrOPoaMg== From: Kalle Valo To: nbd@nbd.name Cc: lorenzo.bianconi@redhat.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] wifi: mt76: mt7915: workaround dubious x | !y warning References: <20240325155838.1558680-1-kvalo@kernel.org> Date: Mon, 25 Mar 2024 19:22:38 +0200 In-Reply-To: <20240325155838.1558680-1-kvalo@kernel.org> (Kalle Valo's message of "Mon, 25 Mar 2024 17:58:38 +0200") Message-ID: <87cyri1b1d.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Kalle Valo writes: > Sparse warns: > > drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y > > Workaround it by using the '?' operator. Compile tested only. > > Signed-off-by: Kalle Valo > --- > v2: > > * use parenthesis Felix&Lorenzo, if this looks ok to you I would like to take this directly to wireless-next. I'm aiming that the next wireless-next pull request is sparse warning free :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches