Received-SPF: pass (google.com: domain of linux-wireless+bounces-5228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <973efc2cb87812f512fd33f354a91da17e3d8564.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: Ensure links are cleaned up when driver
 fails.
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless
	 <linux-wireless@vger.kernel.org>
Date: Mon, 25 Mar 2024 18:43:32 +0100
In-Reply-To: <6bed94b3-4674-7fe9-ee82-bac7f9c7ffd6@candelatech.com>
References: <20231111001023.1335122-1-greearb@candelatech.com>
	 <5fe480c4-fa39-1d29-a5e9-ba2447b08dd2@candelatech.com>
	 <449f6afbc20c57f704dbeabc3a8eac8fec676405.camel@sipsolutions.net>
	 <6bed94b3-4674-7fe9-ee82-bac7f9c7ffd6@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-03-25 at 10:40 -0700, Ben Greear wrote:
> It is needed because if FW crashes while you are trying to remove links, =
then link
> removal would fail, which causes mac80211 to not clean up its links.

OK. It should get back to some legal state after recovery though?

> In case where you
> are trying to delete the station, this causes un-cleaned links which caus=
ed crashes
> back when I was creating this patch.  My patch allows always cleaning up =
the links
> regardless of driver errors in the teardown paths.

Seems potentially more like driver errors. Or perhaps we should just
ignore driver errors entirely?

> Always possible some intervening changes made this less of a problem, esp=
ecially since
> MLO is disabled for be200 in upstream code anyway now.

Well that's just temporary, but we've also done a lot of work on FW
error recovery, though likely unrelated to this particular issue.

> I can remove the extra logging if you are otherwise OK with the approach
> but don't want the logs.

Well it'd be nice to actually see what crashed, and maybe it should
really be driver fixes? I don't really understand why mac80211 would
crash on failure of link removal.

johannes