Received-SPF: pass (google.com: domain of linux-wireless+bounces-5285-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
  "konstantin.kletschke@inside-m2m.de" <konstantin.kletschke@inside-m2m.de>
Subject: Re: AP mode on RTW88 8821cs
References: <ZfwSM0paZg23iEPS@hephaistos.inside-m2m.de>
	<be67119238e14fa09b3d9dc848d8edd9@realtek.com>
	<87wmpu1do6.fsf@kernel.org>
	<2fcab17428576577cbf47bc9551c44f5bac0ea95.camel@realtek.com>
Date: Tue, 26 Mar 2024 17:47:07 +0200
In-Reply-To: <2fcab17428576577cbf47bc9551c44f5bac0ea95.camel@realtek.com>
	(Ping-Ke Shih's message of "Tue, 26 Mar 2024 01:57:05 +0000")
Message-ID: <87y1a56lms.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Fri, 2024-03-22 at 17:36 +0200, Kalle Valo wrote:
>> 
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > We had similar discussion before [1]. I think Martin will take his time to
>> > investigate how to enable AP mode on SDIO WiFi cards.
>> > 
>> > [1]
>> > https://lore.kernel.org/linux-wireless/36972ff5-0c48-4bd2-8f9a-9649bfa24225@lexina.in/
>> 
>> If AP mode is broken on SDIO devices it would be user friendly to
>> disable AP mode support (NL80211_IFTYPE_AP in wiphy->interface_modes) on
>> SDIO until the issues are fixed. In other words, the driver should only
>> enable features which work reliably.
>> 
>
> I made a patch [1] to set station mode only for SDIO devices.

Very nice, thanks Ping.

> Meanwhile, I would like to remove mesh point support from rtw88
> because I don't have impression that it can work and someone uses
> that.

Yeah, if you are not 100% sure that mesh works then it's better to
remove it from rtw88. If out of some miracle the mesh mode would
actually work, I'm sure someone will then report that to us and we can
add it back to rtw88.