Received-SPF: pass (google.com: domain of linux-wireless+bounces-5294-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a313c313ab41325843092dc8445386dd802ed115.camel@sipsolutions.net>
Subject: Re: [PATCH 01/10] wifi: mac80211: Add EHT UL MU-MIMO flag in
 ieee80211_bss_conf
From: Johannes Berg <johannes@sipsolutions.net>
To: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>, 
	ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Tue, 26 Mar 2024 19:32:49 +0100
In-Reply-To: <b4fb2e9f-b7af-42da-be97-9ae1560ebad2@quicinc.com>
References: <20240325201031.10837-1-quic_pradeepc@quicinc.com>
	 <20240325201031.10837-2-quic_pradeepc@quicinc.com>
	 <8efc258b698acd504c1fc699d026b906bf383894.camel@sipsolutions.net>
	 <b4fb2e9f-b7af-42da-be97-9ae1560ebad2@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-03-26 at 11:31 -0700, Pradeep Kumar Chitrapu wrote:
>=20
> On 3/26/2024 6:00 AM, Johannes Berg wrote:
> > On Mon, 2024-03-25 at 13:10 -0700, Pradeep Kumar Chitrapu wrote:
> > > Add flag for Full Bandwidth UL MU-MIMO for EHT. This is utilized
> > > to pass EHT MU-MIMO configurations from user space to driver in
> > > AP mode.
> >=20
> > This ^^ doesn't match this:
> >=20
> > > + * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception=
 (AP) or transmission
> > > + *	(non-AP STA) of an EHT TB PPDU on an RU that spans the entire PPD=
U
> > > + *	bandwidth
> > >=20
> >=20
> > which doesn't match the implementation ... Wouldn't be a bad idea to
> > actually do what it documents though, I guess?
> >=20
> Thanks Johannes for review.
> can you please help clarify what you meant by "actually do what it=20
> documents"? This will help me to amend next revision appropriately.
>=20
> I have tried to describe what this flag is trying to represent.

Yes but ... you document AP and non-AP STA, but only implemented it for
AP?

johannes