Received-SPF: pass (google.com: domain of linux-wireless+bounces-5293-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <b4fb2e9f-b7af-42da-be97-9ae1560ebad2@quicinc.com>
Date: Tue, 26 Mar 2024 11:31:35 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 01/10] wifi: mac80211: Add EHT UL MU-MIMO flag in
 ieee80211_bss_conf
Content-Language: en-US
To: Johannes Berg <johannes@sipsolutions.net>, <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240325201031.10837-1-quic_pradeepc@quicinc.com>
 <20240325201031.10837-2-quic_pradeepc@quicinc.com>
 <8efc258b698acd504c1fc699d026b906bf383894.camel@sipsolutions.net>
From: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
In-Reply-To: <8efc258b698acd504c1fc699d026b906bf383894.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/26/2024 6:00 AM, Johannes Berg wrote:
> On Mon, 2024-03-25 at 13:10 -0700, Pradeep Kumar Chitrapu wrote:
>> Add flag for Full Bandwidth UL MU-MIMO for EHT. This is utilized
>> to pass EHT MU-MIMO configurations from user space to driver in
>> AP mode.
> 
> This ^^ doesn't match this:
> 
>> + * @eht_80mhz_full_bw_ul_mumimo: does this BSS support the reception (AP) or transmission
>> + *	(non-AP STA) of an EHT TB PPDU on an RU that spans the entire PPDU
>> + *	bandwidth
>>
> 
> which doesn't match the implementation ... Wouldn't be a bad idea to
> actually do what it documents though, I guess?
> 
> johannes
Thanks Johannes for review.
can you please help clarify what you meant by "actually do what it 
documents"? This will help me to amend next revision appropriately.

I have tried to describe what this flag is trying to represent. This is 
part of EHT MU-MIMO capabilities and driver may want to look at this 
flag for MU-MIMO configurations.

Also this follows other parameters added to struct earlier.
example: 
https://patchwork.kernel.org/project/linux-wireless/patch/1665006886-23874-2-git-send-email-quic_msinada@quicinc.com/