Received-SPF: pass (google.com: domain of linux-wireless+bounces-5301-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240326014707.17458-1-pkshih@realtek.com>
In-Reply-To: <20240326014707.17458-1-pkshih@realtek.com>
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Tue, 26 Mar 2024 20:34:24 +0100
Message-ID: <CAFBinCDdagAbmTBx_4qezbaPwrEK+5YaQhTZm_YjnrMc4OSJ6g@mail.gmail.com>
Subject: Re: [PATCH] wifi: rtw89: station mode only for SDIO chips
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Ping-Ke,

On Tue, Mar 26, 2024 at 2:48=E2=80=AFAM Ping-Ke Shih <pkshih@realtek.com> w=
rote:
>
> Since only station mode has been tested on SDIO chips, only keep it suppo=
rt
> for SDIO chips to reflect correct supported features.
Overall I'm fine with this patch, thanks for taking care of it!

I only have one small comment: the subject line should start with
"wifi: rtw88: ..." (currently it states rtw89)
With that changed:
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Also I'm hoping that some people will step up and find the missing
link to get AP mode working on SDIO chips. I currently don't have time
for this.


Best regards,
Martin