Received-SPF: pass (google.com: domain of linux-wireless+bounces-5316-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e729ac7c7bf91a512679ae6406f7cb9ef548b6fb.camel@sipsolutions.net>
Subject: Re: [PATCH 04/15] wifi: mac80211: simplify non-chanctx drivers
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Date: Wed, 27 Mar 2024 09:09:49 +0100
In-Reply-To: <7dd7ef40-ea25-4c38-a3c4-42262f5d09a9@candelatech.com>
References: <20240129184108.49639-17-johannes@sipsolutions.net>
	 <20240129194108.6d0ead50f5cf.I60d093b2fc81ca1853925a4d0ac3a2337d5baa5b@changeid>
	 <7dd7ef40-ea25-4c38-a3c4-42262f5d09a9@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi,

> Any reason mtk7915 was skipped in this patch?

Huh. Not that I remember! That ... means the driver is entirely non-
functional right now? Ouch.

> I'll test duplicating what was done for 7996, but wanted to make
> sure I'm not missing bigger problems.

Should of course just add the ieee80211_emulate_*_chanctx calls to it,
unless it should be using its own chanctx implementation now.

(I am always surprised to see a relatively modern driver not using its
own chanctx implementation, but that's part of the reason I did that
change in the first place.)

johannes