Received-SPF: pass (google.com: domain of linux-wireless+bounces-5317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,  "linux-wireless@vger.kernel.org"
 <linux-wireless@vger.kernel.org>,  "Larry.Finger@lwfinger.net"
 <Larry.Finger@lwfinger.net>,  "s.l-h@gmx.de" <s.l-h@gmx.de>,
  "chewitt@libreelec.tv" <chewitt@libreelec.tv>
Subject: Re: [PATCH v3 04/12] wifi: rtlwifi: Add rtl8192du/table.{c,h}
References: <7f4b3309-1580-48f3-9426-29f1eb4052fd@gmail.com>
	<ed50254c-889e-4dcd-93db-f63b776e3503@gmail.com>
	<5170c29a7b565fdec2e004f9391d325328ef5a72.camel@realtek.com>
	<8a90f3cb-7218-4f23-8aa7-fcc68e2f4a93@gmail.com>
Date: Wed, 27 Mar 2024 11:18:42 +0200
In-Reply-To: <8a90f3cb-7218-4f23-8aa7-fcc68e2f4a93@gmail.com> (Bitterblue
	Smith's message of "Tue, 26 Mar 2024 19:30:11 +0200")
Message-ID: <87y1a4yqvh.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:

>>> --- /dev/null
>>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
>>> @@ -0,0 +1,1675 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
>>> +
>>> +#include <linux/types.h>
>>> +
>>> +#include "table.h"
>>> +
>>> +u32 rtl8192du_phy_reg_2tarray[PHY_REG_2T_ARRAYLENGTH] = {
>> 
>> static const ?
>> 
>>> +
>>> +u32 rtl8192du_phy_reg_array_pg[PHY_REG_ARRAY_PG_LENGTH] = {
>> 
>> static const ?
>> 
>
> I can make them static if I move them to table.h. Only phy.c
> includes this header, so that should be fine.

Do note that .h files can't contain static variables, otherwise there
will be duplicate data.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches