Received-SPF: pass (google.com: domain of linux-wireless+bounces-5360-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 27 Mar 2024 15:38:01 +0100
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: mt76: mt7915: workaround dubious x | !y warning
Message-ID: <ZgQvSfUZWFv-M4gk@lore-rh-laptop>
References: <20240325155838.1558680-1-kvalo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qJHP70e4fn2gEJ5N"
Content-Disposition: inline
In-Reply-To: <20240325155838.1558680-1-kvalo@kernel.org>


--qJHP70e4fn2gEJ5N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Sparse warns:
>=20
> drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubio=
us: x | !y
>=20
> Workaround it by using the '?' operator. Compile tested only.

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

>=20
> Signed-off-by: Kalle Valo <kvalo@kernel.org>
> ---
> v2:
>=20
> * use parenthesis
>=20
>  drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c b/driver=
s/net/wireless/mediatek/mt76/mt7915/debugfs.c
> index 450f4d221184..578013884e43 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c
> @@ -523,7 +523,8 @@ mt7915_fw_debug_wm_set(void *data, u64 val)
> =20
>  	/* WM CPU info record control */
>  	mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0));
> -	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm);
> +	mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) |
> +		(dev->fw.debug_wm ? 0 : BIT(0)));
>  	mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5));
>  	mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5));
> =20
> --=20
> 2.39.2
>=20
>=20

--qJHP70e4fn2gEJ5N
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZgQvRwAKCRA6cBh0uS2t
rNjXAQCzC/9/TA4UHhHYicEvu3HZYtugq0+KIcj7diJpoI4A2gD/YeKqb6Tbsr18
DiWSa4w2iXFvC90naP31zhYo0Bu5FQA=
=w8wz
-----END PGP SIGNATURE-----

--qJHP70e4fn2gEJ5N--