Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp136271lqo; Wed, 27 Mar 2024 08:52:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX51dZDOvdhIVlaxR7ScRjvs/luQCYgYMCzWso/NFyVgDeitSGKRlPQzdqeqCayEk3QXkdOBFyq0Yw3LRNH9o2o7DDqMKDFAmf1mu9ndQ== X-Google-Smtp-Source: AGHT+IG5oCthskwWvw+K+6FXofjHX3PUaT1fmFJK2fa59SLHlG9Px1peAQxEGgWYc+IyFDqSpSA1 X-Received: by 2002:a05:6a00:4b50:b0:6e7:7fc6:1484 with SMTP id kr16-20020a056a004b5000b006e77fc61484mr432697pfb.10.1711554750090; Wed, 27 Mar 2024 08:52:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711554750; cv=pass; d=google.com; s=arc-20160816; b=IAB7v1H6j9Vvrf34H1tkJUd69xv0J70zS9wOchrYLJIOLdjiq57VCk9GHFytotonGA mVJT7ncxo/Jr0wHskTcg859ShlVkwbOxlM4MmS+A6tywsuKO98ELwg/9N2QO1/m8sdZn TESqWyN74ctkLuOcr7Y33tOUVHaLbxs/0/CRDqEqse2tnz1Pr2A5sEkEEATWJ3LMhHSM QNZrMhhtmSD4CtY88lmx2fPQ7E7B8YMkSj1AS5IBAPPD4sIIblscrU8afgmZAIM5G0sy JX+f5gXgcUcjB7P1u8/w5jeVsvPEUqThqjDa3UwxELGc/YwYlB/V5dxOSzHnkrYTGEuO ZaAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=8DoMiz8HpEkPB1xE3p2eeM8oOzoz/X+6OQFWHtIe7wY=; fh=AUB6/ncD112TK/WYJcg/Q9NO3syVoniVIzBxWcXVZ5I=; b=KWXBsz13eihkmMasxZ2F0Q39B5FCCBW7M+l6zHNcb04ngfHYUsr+F3fEEWc0uKOi0b X9LstFevW5xvj6D4Xzzx3qDNbiqrGov9tAqO4habpttXYXglk/1O3Rh5p+rbwtwQmXVE /ydtGtoHgRHQfY3z1WxXstU6SaAx3EVcSNqr0048WewZ+TGZvd7yKW4XpHeAgAFcsbUF hN8+7RZwiSaiP1YtDnrh2REIl/cAS+KBm+Ua4JIfdmKJz3q67Gz6/fnc9qZFU00MYqjz gAWLAyl/mYlDmNdsqcrK1MCap/S+Vl54wj5a7vVICS4iajmOeokjy9yjIx3wlfc9RJUf S13Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iz9Gw0BZ; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-5367-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5367-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f6-20020a056a00238600b006eab7ca0061si4422875pfc.229.2024.03.27.08.52.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:52:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5367-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iz9Gw0BZ; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-5367-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5367-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A1E42294D8A for ; Wed, 27 Mar 2024 15:47:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8730D127B5A; Wed, 27 Mar 2024 15:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="iz9Gw0BZ" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DC15134CC0; Wed, 27 Mar 2024 15:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554280; cv=none; b=WV1IzF0lI0ejK2M5ZCdcSHCrEdL3BGjIlVgOoDCA+cuvP/DACHx8Ui8a2ftdITA/9Ihu6TI3S8ff1b9i6AWhmqPjUnu46nvH8JZ4WhOYQs5WVvqQ3a4MVyXDB/J2WKJjI/2KefjLeHON7tHfK23968zwqOk+FHiEfOm/H3Euvwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554280; c=relaxed/simple; bh=8RixWcSd2JJyYLHi087rVeRA/JkQ9IP17D2hcMIULYE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=k+iPlsZl9l5f3gZ9Hucr12CJJVV2nnfjB3ntYFqIN1mL9U2TCwmwpWlpsmBH6gqAQgJ2QwbX3tqfA8eqUoV8mBLl0r29jhcuajSG2QOXdkP1PuU8ecjRorc0qNRthKSMCYuLcLMAjAKuBauOCXBLhGg2dRx79LLWw7BcXW4BE4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=iz9Gw0BZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42RAQv8N021075; Wed, 27 Mar 2024 15:42:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=8DoMiz8HpEkPB1xE3p2eeM8oOzoz/X+6OQFWHtIe7wY=; b=iz 9Gw0BZH1FCzh/4v+cjUrBF3yu2dGmd6sCW2zGkJcdN++RmMIgqUfCnsYEabQvpOp spjRvN7LNJKyXd3/1sbNdZUZDh0LF0xSvpWK8FOBlmNhG6EoK+G/ScQ95C0NAfBM 6o6dETSN7ylfYeZeuRhJ69sJd9Td3sFVrQXt2hCSG07ekvOmjGBsKCWUlkfZ1H3P djK51e4W6ywekm69jkbNb8s6rlWuAY81DYXraYrdz+eUoW/VmsYP4EW2UJhz6em2 YZ1I9WxzUvXOPuzVoMxAm23mwapO4p9BJRVgMkQlnhcMWTaWvJH2wf9YoKHqZJ8G mKlxItByWUJxwu8dZh6A== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3x4etk9atv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Mar 2024 15:42:57 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42RFgucx017852 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 27 Mar 2024 15:42:56 GMT Received: from [10.110.28.48] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 27 Mar 2024 08:42:56 -0700 Message-ID: <00b1703a-47d7-4dc1-a3cd-f07f1a24db92@quicinc.com> Date: Wed, 27 Mar 2024 08:42:55 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically Content-Language: en-US To: Jakub Kicinski , Breno Leitao CC: Kalle Valo , Jeff Johnson , , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , open list References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> <20240321072821.59f56757@kernel.org> <5039256c-03eb-4cda-8d11-49e4561cf1ef@quicinc.com> <20240321151744.246ce2d0@kernel.org> <20240322082336.49f110cc@kernel.org> <20240327074516.624b7ecf@kernel.org> From: Jeff Johnson In-Reply-To: <20240327074516.624b7ecf@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 9t0qFKztIXR9CV8_LmGTXfCo6DyZLgh_ X-Proofpoint-ORIG-GUID: 9t0qFKztIXR9CV8_LmGTXfCo6DyZLgh_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-27_12,2024-03-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 mlxlogscore=882 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403270108 On 3/27/2024 7:45 AM, Jakub Kicinski wrote: > On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote: >> -void init_dummy_netdev(struct net_device *dev) >> +void init_dummy_netdev_core(struct net_device *dev) > > Can init_dummy_netdev_core() be a static function (and no export)? > alloc_netdev_dummy() is probably going to be the only user. > > I'd also lean towards squashing the two commits into one. And once all of the conversions are complete, won't init_dummy_netdev() no longer be used and can be removed?