Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp154541lqo; Wed, 27 Mar 2024 09:17:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXf7jwTd9X5baZsJEqcDBdU/Q351s0Ur7J/jf/Kr6gqU4N6r1zJwkPAaKQglXj9ObE7lltqNRpSocawHKZjRofybl8BHSFcY+piCVWlQQ== X-Google-Smtp-Source: AGHT+IH4WCsV4eKVShRRUAHY0nHUG2cg/46X+7CdGvvioHDa2pQR4M7Qkh5kcptGhKqx4fQD32lj X-Received: by 2002:a05:6808:318a:b0:3c3:7e22:7f7f with SMTP id cd10-20020a056808318a00b003c37e227f7fmr458943oib.9.1711556241095; Wed, 27 Mar 2024 09:17:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711556241; cv=pass; d=google.com; s=arc-20160816; b=gVzwRWu8pZox7zwXGAPhcegJZwl3hAT18HlKWtlazAKdNChYVNpElG8qrDFeEXRRH3 LOVTW4vcZ+pz1ODS3PylsaPl5zV32Y3RktORszaMdin+fpWTpt8v3Us10jsG5mAe+Pkg 7Rc1La3fIMVMCWDEyk81Sd43vjSG1TkSocUVlYzmrjSnv1tYFPNnQGgqJ4gcQISwjDAY u16wiYPUiRDzGzyDZYQ0xc/dASS2HU5AGM0aVzlIiHGYVtFP52MNteLsXt23CsoXL2M1 8+dqXCzMgrD7qbQi4lvnfA5UFx1MekHT+3m1TW6jsDhUFqnWHFJBwpgBZL+Zhjm9KOz4 2DIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=b4YJvO6MabuKaosr/db7Mxpxk1nahKdSpT7lsmsSoSE=; fh=78aS6OSbQca+AmLri7x7TjGL6CS3tiUzr5vx0S9bN/A=; b=BlUV/ZAciBaTy7Vv/0FHyaQZR7c/vhbVRnG7IL821n1xORGoRYKOQu6RTRbkE6UxzM NSmAg6QRGxaAORVCkasbeuRsCcQzoPkJduyasH8SDMELRsctalRTcTg9Xi6DKEts3Eov V3aprOt1sxmgxTdWMNRYkvB9q9wI0VrADGIFruIDQyf8VQ88y7K++FqUs705zG8VoivV lURsI2/vqJEkBwSJNo5Gu2Lx0DjGlUzYbG6ChKOzhkNNTGGpJavO7FCcJpebUf2TQ6ni nXfrSxcPxNFkYuDwjUpnpGTXjyyBg9aXZmTFfAAhFGYeJyZh0oKBw1joGYK16KQDlff2 wwxw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwYmau2c; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5371-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id jt5-20020a05621427e500b00696aa37150esi2146469qvb.112.2024.03.27.09.17.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 09:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwYmau2c; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5371-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C4E5F1C2F109 for ; Wed, 27 Mar 2024 16:17:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3DF2812EBEE; Wed, 27 Mar 2024 16:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BwYmau2c" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DD4C4F890; Wed, 27 Mar 2024 16:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556230; cv=none; b=USqcwfCEHDt1uLM3AwznLeAob0nrPOPCNBLzUOuEmS6pDwThpJJOiDgUK08nwmvsTdLBDy1jRMfEg7Ec83+YnEdccia5YzogWe/vwtKeSjH0rLzGyzERvPidKhrTDkl2/fpjSRTfJx0QEpLMLfpO+uV8ntgZUVookLIIGAjRldk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556230; c=relaxed/simple; bh=f61So1Ws0SkXaOlt+8mMWwfTLUxvYSQ7nKISq+0qW/0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s/MZybNy9vzsXX3OcCPCJRUu0Lppu3sBPmVGLphmaA989Jh+3O50izCPmXubfvZLJhCzZMDKT0fAcDx9Og54DJZa2CfXWsBZRTgkH53patp8T8a1kiNRZwe65Kuus7gMG5Qn7p3ioufO4R0fkR7ikWNM8Nd5AraZzuYQv5btJIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BwYmau2c; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B22C433C7; Wed, 27 Mar 2024 16:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711556229; bh=f61So1Ws0SkXaOlt+8mMWwfTLUxvYSQ7nKISq+0qW/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BwYmau2cQyr+8vTxiCxY9LvjzuGCkA/QJKuycvxKZt0fc1iTkZiFx/wTI86Ci8ZZ/ rU3wcvTLPgZklkueylDcFpGULYZ+6yg7PKMZSDTAKgMF/cOUe79kf0jVTZY5ljN0Ua f8pJ/EfUFN2sRyre4dfbeGOr4RjhTLDPKqHK6xoDLGn6vMKcdQquFjkBmvyi5A8jtK UlAW0nANLW6z/eMsESsMEhQy3X9MEcOJ0uxsexTe+6cDC227KsX0uk/KTeG31dLCR+ 5Cqeke57J2SD4BQnLa+Lo3p0rARIpKgRpCzDC/rtQWDcf9QvXo6Sz56XeKcvLl798s jCb/01fXIEwmw== Date: Wed, 27 Mar 2024 09:17:08 -0700 From: Jakub Kicinski To: Jeff Johnson Cc: Breno Leitao , Kalle Valo , Jeff Johnson , , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , open list Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically Message-ID: <20240327091708.553f2251@kernel.org> In-Reply-To: <00b1703a-47d7-4dc1-a3cd-f07f1a24db92@quicinc.com> References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> <20240321072821.59f56757@kernel.org> <5039256c-03eb-4cda-8d11-49e4561cf1ef@quicinc.com> <20240321151744.246ce2d0@kernel.org> <20240322082336.49f110cc@kernel.org> <20240327074516.624b7ecf@kernel.org> <00b1703a-47d7-4dc1-a3cd-f07f1a24db92@quicinc.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 08:42:55 -0700 Jeff Johnson wrote: > On 3/27/2024 7:45 AM, Jakub Kicinski wrote: > > On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote: > >> -void init_dummy_netdev(struct net_device *dev) > >> +void init_dummy_netdev_core(struct net_device *dev) > > > > Can init_dummy_netdev_core() be a static function (and no export)? > > alloc_netdev_dummy() is probably going to be the only user. > > > > I'd also lean towards squashing the two commits into one. > > And once all of the conversions are complete, won't init_dummy_netdev() no > longer be used and can be removed? That's right, it should be removed. But it may take another release cycle until we can do that, depending on how quickly the patches propagate :(