Received-SPF: pass (google.com: domain of linux-wireless+bounces-5373-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d0cfe92b-c696-4a60-9eaf-f81f6ee5e75f@quicinc.com>
Date: Wed, 27 Mar 2024 09:34:34 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 04/12] wifi: rtlwifi: Add rtl8192du/table.{c,h}
Content-Language: en-US
To: Ping-Ke Shih <pkshih@realtek.com>, "kvalo@kernel.org" <kvalo@kernel.org>,
        "rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        "s.l-h@gmx.de"
	<s.l-h@gmx.de>,
        "chewitt@libreelec.tv" <chewitt@libreelec.tv>
References: <7f4b3309-1580-48f3-9426-29f1eb4052fd@gmail.com>
 <ed50254c-889e-4dcd-93db-f63b776e3503@gmail.com>
 <5170c29a7b565fdec2e004f9391d325328ef5a72.camel@realtek.com>
 <8a90f3cb-7218-4f23-8aa7-fcc68e2f4a93@gmail.com> <87y1a4yqvh.fsf@kernel.org>
 <5d117cf09134b034e704b8a1b5167235963a9c88.camel@realtek.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <5d117cf09134b034e704b8a1b5167235963a9c88.camel@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/27/2024 2:30 AM, Ping-Ke Shih wrote:
> On Wed, 2024-03-27 at 11:18 +0200, Kalle Valo wrote:
>>
>> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
>>
>>>>> --- /dev/null
>>>>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/table.c
>>>>> @@ -0,0 +1,1675 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0
>>>>> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
>>>>> +
>>>>> +#include <linux/types.h>
>>>>> +
>>>>> +#include "table.h"
>>>>> +
>>>>> +u32 rtl8192du_phy_reg_2tarray[PHY_REG_2T_ARRAYLENGTH] = {
>>>>
>>>> static const ?
>>>>
>>>>> +
>>>>> +u32 rtl8192du_phy_reg_array_pg[PHY_REG_ARRAY_PG_LENGTH] = {
>>>>
>>>> static const ?
>>>>
>>>
>>> I can make them static if I move them to table.h. Only phy.c
>>> includes this header, so that should be fine.
>>
>> Do note that .h files can't contain static variables, otherwise there
>> will be duplicate data.
>>
> 
> Indeed, so these cases should be 'const u32', no need 'static'. 
> 
> 
Or make them static and have accessor functions to return pointers to the tables