Received-SPF: pass (google.com: domain of linux-wireless+bounces-5450-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <550cc81a3dffd07ec1235dc32fd7bbde22d9bf57.camel@sipsolutions.net>
Subject: Re: [syzbot] [wireless?] WARNING in kcov_remote_start (3)
From: Johannes Berg <johannes@sipsolutions.net>
To: syzbot <syzbot+0438378d6f157baae1a2@syzkaller.appspotmail.com>, 
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org, 
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, 
	netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Cc: Andrey Konovalov <andreyknvl@gmail.com>, Dmitry Vyukov
 <dvyukov@google.com>,  Aleksandr Nogikh <nogikh@google.com>
Date: Thu, 28 Mar 2024 12:45:10 +0100
In-Reply-To: <0000000000007b02500614b66e31@google.com>
References: <0000000000007b02500614b66e31@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-28 at 04:00 -0700, syzbot wrote:
>=20
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 2400 at kernel/kcov.c:860 kcov_remote_start+0x549/0x=
7e0 kernel/kcov.c:860

This is

        /*
         * Check that kcov_remote_start() is not called twice in background
         * threads nor called by user tasks (with enabled kcov).
         */
        mode =3D READ_ONCE(t->kcov_mode);
        if (WARN_ON(in_task() && kcov_mode_enabled(mode))) {
                local_unlock_irqrestore(&kcov_percpu_data.lock, flags);
                return;
        }

but I have no idea what that even means?

> Workqueue: events_unbound cfg80211_wiphy_work
> RIP: 0010:kcov_remote_start+0x549/0x7e0 kernel/kcov.c:860
...
> Call Trace:
>  <TASK>
>  kcov_remote_start_common include/linux/kcov.h:48 [inline]
>  ieee80211_iface_work+0x21f/0xf10 net/mac80211/iface.c:1654
>  cfg80211_wiphy_work+0x221/0x260 net/wireless/core.c:437
>  process_one_work kernel/workqueue.c:3218 [inline]
>  process_scheduled_works+0xa2c/0x1830 kernel/workqueue.c:3299
>  worker_thread+0x86d/0xd70 kernel/workqueue.c:3380

It's a worker thread. Was this not intended to be called in threads?

johannes