Received-SPF: pass (google.com: domain of linux-wireless+bounces-5470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <968024261cf1d4e72832451e1c4cc64922d05364.camel@sipsolutions.net>
Subject: Re: No way to cancel SAE after CMD_AUTHENTICATE?
From: Johannes Berg <johannes@sipsolutions.net>
To: James Prestwood <prestwoj@gmail.com>, "open list:MEDIATEK MT76
	WIRELESS LAN DRIVER" <linux-wireless@vger.kernel.org>
Date: Thu, 28 Mar 2024 17:05:23 +0100
In-Reply-To: <055b857a-83f0-4abb-b6ff-f0eaaf572e64@gmail.com>
References: <055b857a-83f0-4abb-b6ff-f0eaaf572e64@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-28 at 08:23 -0700, James Prestwood wrote:
> Hi,
>=20
> I noticed some odd behavior where userspace is unable to cancel an SAE=
=20
> connection until associated. If you issue a CMD_AUTHENTICATE then=20
> immediately (or prior to association) send a CMD_DISCONNECT the kernel=
=20
> will not cancel the authentication and afaict ignore the CMD_DISCONNECT.=
=20
> The kernel will continue to send authenticate events, and even retry=20
> authentication until the retry limit after CMD_DISCONNECT is issued.
>=20
> I see the checks in cfg80211_disconnect which seem to back up this=20
> behavior where its essentially ignored if not "connected". I'm not sure=
=20
> where to actually fix this since the auth retries are internal to=20
> mac80211. Since the device isn't even authenticated I'm unsure what=20
> value/structure to even check in order to detect this situation and=20
> clean up. But there needs to be some way to cancel the authentication,=
=20
> right?

NL80211_CMD_DEAUTHENTICATE should do that? I'm not really surprised you
cannot disconnet when you're not even connected yet, for the most part
the kernel doesn't care about tracking auth state (any more, for many
years now).

johannes