Received-SPF: pass (google.com: domain of linux-wireless+bounces-5487-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <3f77e4e0455fbfdec7e14777cf116175eae32f49.camel@sipsolutions.net>
Subject: Re: [RFC 2/2] wifi: mac80211: Add support for link reconfigure
 removal
From: Johannes Berg <johannes@sipsolutions.net>
To: Manish Dharanenthiran <quic_mdharane@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Thu, 28 Mar 2024 19:23:14 +0100
In-Reply-To: <20240328055235.3034174-3-quic_mdharane@quicinc.com>
References: <20240328055235.3034174-1-quic_mdharane@quicinc.com>
	 <20240328055235.3034174-3-quic_mdharane@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-03-28 at 11:22 +0530, Manish Dharanenthiran wrote:
>=20
> +int __ieee80211_link_reconfig_remove(struct ieee80211_local *local,
> +				     struct ieee80211_sub_if_data *sdata,
> +				     const struct cfg80211_link_reconfig_removal_params *params)
> +{
> +	struct ieee80211_link_data *link;
> +	int ret;
> +
> +	if (!ieee80211_sdata_running(sdata))
> +		return -ENETDOWN;
> +
> +	if (sdata->vif.type !=3D NL80211_IFTYPE_AP)
> +		return -EINVAL;
> +
> +	link =3D sdata_dereference(sdata->link[params->link_id], sdata);
> +	if (!link)
> +		return -ENOLINK;
> +
> +	ret =3D drv_link_reconfig_remove(local, sdata, params);
> +
> +	return ret;

Again ... remove the 'ret' variable, it serves no purpose at all.

> +}
> +
> +int ieee80211_update_link_reconfig_remove_status(struct ieee80211_vif *v=
if,
> +						 unsigned int link_id,
> +						 u8 tbtt_count, u64 tsf,
> +						 enum ieee80211_link_reconfig_remove_state status)
> +{
> +	struct ieee80211_sub_if_data *sdata =3D vif_to_sdata(vif);
> +
> +	if (vif->type !=3D NL80211_IFTYPE_AP) {
> +		sdata_err(sdata, "Discarding link reconfig status for unsupported vif =
type\n");

Uh, no. Remove that message please.

> +TRACE_EVENT(drv_link_reconfig_remove,
> +	    TP_PROTO(struct ieee80211_local *local,
> +		     struct ieee80211_sub_if_data *sdata,
> +		     const struct cfg80211_link_reconfig_removal_params *params),
> +
> +	TP_ARGS(local, sdata, params),
> +
> +	TP_STRUCT__entry(LOCAL_ENTRY
> +			 VIF_ENTRY
> +			 __field(u32, link_id)
> +			 __field(u16, count)
> +			 __dynamic_array(u8, frame, params->ie_len)
> +	),

All the same things about indentation apply here.

johannes