Received-SPF: pass (google.com: domain of linux-wireless+bounces-5496-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ab738886-f7e3-43ab-8615-2164e8414786@quicinc.com>
Date: Thu, 28 Mar 2024 14:02:37 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 1/2] wifi: cfg80211/mac80211: Introduce nl80211 commands to
 support MLD link removal offload
Content-Language: en-US
To: Manish Dharanenthiran <quic_mdharane@quicinc.com>,
        <johannes@sipsolutions.net>
CC: <linux-wireless@vger.kernel.org>,
        Rameshkumar Sundaram
	<quic_ramess@quicinc.com>
References: <20240328055235.3034174-1-quic_mdharane@quicinc.com>
 <20240328055235.3034174-2-quic_mdharane@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240328055235.3034174-2-quic_mdharane@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/27/2024 10:52 PM, Manish Dharanenthiran wrote:
[...]
> +/**
> + * cfg80211_update_link_reconfig_remove_status - Inform userspace about
> + *	the removal status of link which is scheduled for removal
> + * @dev: the device on which the operation is requested
> + * @link_id: Link which is undergoing removal
> + * @tbtt_count: Current tbtt_count to be updated.
> + * @tsf: Beacon's timestamp value
> + * @status: Inform started or completed action to userspace based on the value

kernel-doc warns:

include/net/cfg80211.h:9573: warning: Function parameter or struct member 'action' not described in 'cfg80211_update_link_reconfig_remove_status'
include/net/cfg80211.h:9573: warning: Excess function parameter 'status' description in 'cfg80211_update_link_reconfig_remove_status'


> + *	received,
> + *	i) 0 (IEEE80211_LINK_RECONFIG_START) - Send
> + *		NL80211_CMD_LINK_REMOVAL_STARTED
> + *	ii) 1 (IEEE80211_LINK_RECONFIG_COMPLETE) - Send
> + *		NL80211_CMD_LINK_REMOVAL_COMPLETED
> + *
> + *
> + * This function is used to inform userspace about the ongoing link removal
> + * status. 'IEEE80211_LINK_RECONFIG_START' is issued when the first beacon with
> + * ML reconfigure IE is sent out. This event can be used by userspace to start
> + * the BTM in case of AP mode. And, IEEE80211_LINK_RECONFIG_COMPLETE is issued
> + * when the last beacon is sent with ML reconfigure IE. This is used to
> + * initiate the deletion of that link, also to trigger deauth/disassoc for the
> + * associated peer(s).
> + *
> + * Note: This API is currently used by drivers which supports offloaded
> + * Multi-Link reconfigure link removal. Returns failure if FEATURE FLAG is not
> + * set or success if NL message is sent.
> + */
> +int
> +cfg80211_update_link_reconfig_remove_status(struct net_device *dev,
> +					    unsigned int link_id,
> +					    u8 tbtt_count, u64 tsf,
> +					    enum ieee80211_link_reconfig_remove_state action);
> +
>  #endif /* __NET_CFG80211_H */
[...]

/jeff