Received-SPF: pass (google.com: domain of linux-wireless+bounces-5498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
To: Arnd Bergmann <arnd@kernel.org>, Kees Cook <keescook@chromium.org>,
 Kalle Valo <kvalo@kernel.org>
Cc: linux-hardening@vger.kernel.org, linux-wireless@vger.kernel.org, Arnd
 Bergmann <arnd@arndb.de>, Jeff Johnson <quic_jjohnson@quicinc.com>, Dmitry
 Antipov <dmantipov@yandex.ru>, Hancheng Yang <hyang@freebox.fr>, Remi
 Pommarel <repk@triplefau.lt>, Johannes Berg <johannes.berg@intel.com>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] wifi: ath9k: work around memset overflow warning
In-Reply-To: <20240328135509.3755090-3-arnd@kernel.org>
References: <20240328135509.3755090-1-arnd@kernel.org>
 <20240328135509.3755090-3-arnd@kernel.org>
Date: Thu, 28 Mar 2024 22:14:45 +0100
Message-ID: <87wmpm12ka.fsf@toke.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Arnd Bergmann <arnd@kernel.org> writes:

> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc-9 and some other older versions produce a false-positive warning
> for zeroing two fields
>
> In file included from include/linux/string.h:369,
>                  from drivers/net/wireless/ath/ath9k/main.c:18:
> In function 'fortify_memset_chk',
>     inlined from 'ath9k_ps_wakeup' at drivers/net/wireless/ath/ath9k/main=
.c:140:3:
> include/linux/fortify-string.h:462:25: error: call to '__write_overflow_f=
ield' declared with attribute warning: detected write beyond size of field =
(1st parameter); maybe use struct_group()? [-Werror=3Dattribute-warning]
>   462 |                         __write_overflow_field(p_size_field, size=
);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Using a struct_group seems to reliably avoid the warning and
> not make the code much uglier. The combined memset() should even
> save a couple of cpu cycles.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>