Received-SPF: pass (google.com: domain of linux-wireless+bounces-5612-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e826a505-05e0-4761-ac22-97d6bfe175b6@quicinc.com>
Date: Fri, 29 Mar 2024 10:45:48 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth
 support
Content-Language: en-US
To: <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>
References: <20240327170910.23975-1-quic_pradeepc@quicinc.com>
From: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
In-Reply-To: <20240327170910.23975-1-quic_pradeepc@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/27/2024 10:09 AM, Pradeep Kumar Chitrapu wrote:
> Add support for
> 1. enabling MU-MIMO in HE and EHT modes from hardware
> 2. setting fixed HE rate/GI/LTF
> 3. 160 MHz bandwidth in HE mode
> 4. extended NSS bandwidth support
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> changes in v2:
>   - Amend mac80211 patch description as the patch is not specific
>     to AP mode.
>   - Amend EHT MU-MIMO patch description to specify future support
>     for STA mode.
> 
> Pradeep Kumar Chitrapu (10):
>    wifi: mac80211: Add EHT UL MU-MIMO flag in ieee80211_bss_conf
>    wifi: ath12k: push HE MU-MIMO params from hostapd to hardware
>    wifi: ath12k: push EHT MU-MIMO params from hostapd to hardware
>    wifi: ath12k: move HE MCS mapper to a separate function
>    wifi: ath12k: generate rx and tx mcs maps for supported HE mcs
>    wifi: ath12k: fix TX and RX MCS rate configurations in HE mode
>    wifi: ath12k: add support for setting fixed HE rate/GI/LTF
>    wifi: ath12k: clean up 80P80 support
>    wifi: ath12k: add support for 160 MHz bandwidth
>    wifi: ath12k: add extended NSS bandwidth support for 160 MHz
> 
>   drivers/net/wireless/ath/ath12k/core.h |    2 +
>   drivers/net/wireless/ath/ath12k/mac.c  | 1035 ++++++++++++++++++++----
>   drivers/net/wireless/ath/ath12k/mac.h  |   17 +
>   drivers/net/wireless/ath/ath12k/wmi.c  |   24 +-
>   drivers/net/wireless/ath/ath12k/wmi.h  |   98 ++-
>   include/net/mac80211.h                 |    4 +
>   net/mac80211/cfg.c                     |    5 +
>   7 files changed, 981 insertions(+), 204 deletions(-)
> 
> 
> base-commit: fe7e1b830cf3c0272aa4eaf367c4c7b29c169c3d
Hi Kalle/Johannes

I noticed patch status as 'Changes requested', but there were no 
accompanying comments specifying the exact modifications needed.
I kindly request additional information or guidance on the specific 
areas that require correction. Once I have a clearer understanding, I 
will promptly address the necessary fixes.

Thanks
Pradeep