Received-SPF: pass (google.com: domain of linux-wireless+bounces-5613-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <feeaf733-e592-4f9e-b91e-0812bfb0bce9@quicinc.com>
Date: Fri, 29 Mar 2024 10:48:07 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/6] wifi: ath12k: add 6 GHz params in peer assoc command
Content-Language: en-US
To: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
        <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>,
        Avula Sri Charan
	<quic_asrichar@quicinc.com>
References: <20240325212304.28241-1-quic_pradeepc@quicinc.com>
 <20240325212304.28241-5-quic_pradeepc@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240325212304.28241-5-quic_pradeepc@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 3/25/2024 2:23 PM, Pradeep Kumar Chitrapu wrote:
> Currently A-MPDU aggregation parameters are not being configured
> during peer association for 6 GHz band. Hence, extract these
> parameters from station's capabilities received in association
> request and send to firmware. Without this, A-MPDU aggregation
> is not happening in 6 GHz band.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Co-developed-by: Avula Sri Charan <quic_asrichar@quicinc.com>
> Signed-off-by: Avula Sri Charan <quic_asrichar@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/mac.c | 56 ++++++++++++++++++++++++++-
>  1 file changed, 55 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> index 6d7df18ec424..7e296140439a 100644
> --- a/drivers/net/wireless/ath/ath12k/mac.c
> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> @@ -1910,6 +1910,59 @@ static void ath12k_peer_assoc_h_he(struct ath12k *ar,
>  	}
>  }
>  
> +static void ath12k_peer_assoc_h_he_6ghz(struct ath12k *ar,
> +					struct ieee80211_vif *vif,
> +					struct ieee80211_sta *sta,
> +					struct ath12k_wmi_peer_assoc_arg *arg)
> +{
> +	const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap;
> +	struct cfg80211_chan_def def;
> +	enum nl80211_band band;
> +	u8  ampdu_factor;
> +
> +	if (WARN_ON(ath12k_mac_vif_chan(vif, &def)))
> +		return;
> +
> +	band = def.chan->band;
> +
> +	if (!arg->he_flag || band != NL80211_BAND_6GHZ || !sta->deflink.he_6ghz_capa.capa)
> +		return;
> +
> +	if (sta->deflink.bandwidth == IEEE80211_STA_RX_BW_40)
> +		arg->bw_40 = true;
> +
> +	if (sta->deflink.bandwidth == IEEE80211_STA_RX_BW_80)
> +		arg->bw_80 = true;
> +
> +	if (sta->deflink.bandwidth == IEEE80211_STA_RX_BW_160)
> +		arg->bw_160 = true;
> +
> +	if (sta->deflink.bandwidth == IEEE80211_STA_RX_BW_320)
> +		arg->bw_320 = true;
> +
> +	arg->peer_he_caps_6ghz = le16_to_cpu(sta->deflink.he_6ghz_capa.capa);
> +	arg->peer_mpdu_density =
> +		ath12k_parse_mpdudensity(u32_get_bits(arg->peer_he_caps_6ghz,
> +						      IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START));

ath12k-check complains:
drivers/net/wireless/ath/ath12k/mac.c:1946: line length of 93 exceeds 90 columns

git blame flags:
b2b50e659028d (Pradeep Kumar Chitrapu 2024-03-25 14:23:02 -0700 1946)                IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START));

perhaps use a local variable to hold the u32_get_bits() value?