Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2392659lqz; Tue, 2 Apr 2024 16:41:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWd4qWMbkhfwc+vwOg74ZImQz5rdkcKOwyQuRqFXF3Ym+K3E17hfrWE1haO9xJA4ogFu861eOtw4CMBzm4eyO6plfCuvTBZEH/gns5U4Q== X-Google-Smtp-Source: AGHT+IGOqSaXjsqwEkqHr5uIfLeypzs1exuLbIdfWwxJwYEFPmdQBRjS+FwmOvfoFkW5k0a8ZzqJ X-Received: by 2002:a17:906:b852:b0:a4d:d356:fd69 with SMTP id ga18-20020a170906b85200b00a4dd356fd69mr764597ejb.12.1712101287947; Tue, 02 Apr 2024 16:41:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712101287; cv=pass; d=google.com; s=arc-20160816; b=B96flv1xBDVdmKWxR2VydVCILksqfa/7i6PYkXRpnIWzaBLyegxUYyz6M3FKPwAKOn CyIF0tdf8WGQULbiiZN600kCU0bgF1OW/+8uKB1hWjT9YoChfG1bT91c6FarnmTUm9id DEoGub2xkjNBWctSdtEkQU1/Z9xuQlmBl3JRc2qyg+lB9JRNGXztyhfLNH4x5Yhs7Pxv UMdBvUasO3RmEeFQ15KJDilMWN3sDE1479UbS5I+nRWzvROuxZuZ3nIyQ78i5FR+zHlG yBFhgtWZGJ5q/4RUfOXl75XTPNL4btzQFPW8rPMM38ERhUCXO+W5X2LoZun9eOTh8Kcv Covw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=gx3PZFcSWFHU4TY02tA6oCnE7KhZTs0zAG7El9eKypE=; fh=k20WVCMavwkzPVeVDaGBu2Gh8VBTJhHse4A36UHkbJo=; b=wueIwg8Ru0skzDw3mlQwqkMHbOh66fm4iOqQ+SYvAhsO6+XZ1gxVACa9ZnJszCFduy VL32noj3vFg65/4wlXWJyBa9aTQvq6R3zoWYF1Y3pFLr6rrvaW5/vUJpn47usP6Ldidm elF5hHxP9F9rwTYEGAcT8VPec3f8m2z8+0drQG0qrF1Ye3Uw6iz9IyMd+9TyPWIaiCob 9RKCNxgL2UvAWLFe+iIwxtIphKwfWfmkOWM5g7fToLfwLLoCvxTmKL3R2T7pcpXuov5B rsX2LOu2XQgvuxwdYnn+5fvH3+EXdxFniL3s3jTbL6s/NhMmUcWKzTAOWJLfCgGSC7IU YMXw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=DQmavJ29; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-5777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5777-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i22-20020a1709064ed600b00a4e9ac64f26si317630ejv.12.2024.04.02.16.41.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 16:41:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=DQmavJ29; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-wireless+bounces-5777-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5777-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AC94B1F230B5 for ; Tue, 2 Apr 2024 23:41:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96B3F55E72; Tue, 2 Apr 2024 23:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="DQmavJ29" X-Original-To: linux-wireless@vger.kernel.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF5B2260B; Tue, 2 Apr 2024 23:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712101282; cv=none; b=QPPu7SL1MNDkj6nzcl6EHb7dBkxWjyOwpthqojCitPUO2f2y2hab0mA466DyUKmkF48ni94tVIvmIyb/kahQUBWzs+XJIvWY441MNoVaYBlWtbxbKRYanY3Gqc2F0e/7hgOAsqIHH//MyF5ffxepKaNrLVbIjKLg7Gn8Y8Np7wU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712101282; c=relaxed/simple; bh=NXin/CFX1YojPEWwVX6R+yIueZX1D7Uiy76MzAYZC+0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=UYsruK0tF5cd9IiSM10FmRTKtM0jtIL3u7QnnjhwzPPzmpgiidJ1D8DQQrNdTKI5w/HfW8njnCVRaAbhQby/6XjaMeVcyEFHx2CgO8DtheMoYxe9j9rGcq1NIucZz1vk6gIlA1dqE/yib4H77UucgtaOW7pm767tCayHRiV9ITo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=DQmavJ29; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 432MSBEj008798; Tue, 2 Apr 2024 23:41:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=gx3PZFcSWFHU4TY02tA6oCnE7KhZTs0zAG7El9eKypE=; b=DQ mavJ29FARd64t9UeVH9AUcLCv4R4GiRGK72pwlctjr0ethhm4GAxlMZ/8+qRWXf7 Q/m8XsXI6FriDSUtMsxJLloMh/WeZL7Be6yU172BxU+9JeO3I1jRxLw2ZHKCehIB Oee3MpWKVRh6Rd1wl039L3QFwQohPOz8ESgMczFCcvd2+KCI9CEkEzMJP8y1SyxD 99IyyNz8ssLYGEdWqWFFNF2rzi/9ovT6xQJaupPXdz7mtdbMdbVHSkvfX9nlN0AH 2R2RG6lkUy6jS1Ly9xZ8TTrCx+q1W5kHp3M6AKmusXvLALA+EUsKViEXd9wlg1XQ SSGweXG9yTMGiB4nz4vg== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3x8pj4gmwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Apr 2024 23:41:15 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 432NfEW3000862 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 2 Apr 2024 23:41:14 GMT Received: from [10.110.49.129] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 2 Apr 2024 16:41:13 -0700 Message-ID: Date: Tue, 2 Apr 2024 16:41:13 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] wifi: ath10k: fix board file loading for wcn3990 devices Content-Language: en-US To: Dmitry Baryshkov , Kalle Valo CC: , , , Yongqin Liu References: <20240130-wcn3990-board-fw-v1-0-738f7c19a8c8@linaro.org> From: Jeff Johnson In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: pkc1wUj_NbdeQFyAVHSIWvqTpZWu5x-p X-Proofpoint-GUID: pkc1wUj_NbdeQFyAVHSIWvqTpZWu5x-p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-02_14,2024-04-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 bulkscore=0 impostorscore=0 clxscore=1011 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2404020173 On 3/29/2024 9:48 PM, Dmitry Baryshkov wrote: > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > wrote: >> >> The ath10k driver fails to properly handle fallback from board-2.bin to >> board.bin for WCN3990 cards. This happens because the >> ath10k_hw_params_list doesn't include .fw.board* parameters for the >> WCN3990 platform. >> >> Add board data configuration for WCN3990. While we are at it, merge >> common pieces of BDF support: drop .board and .eboard names from struct >> ath10k_hw_params_fw and use the common name instead. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> Dmitry Baryshkov (3): >> wifi: ath10k: populate board data for WCN3990 >> wifi: ath10k: drop chip-specific board data file name >> wifi: ath10k: drop fw.eboard file name >> >> drivers/net/wireless/ath/ath10k/core.c | 32 ++++------------------------- >> drivers/net/wireless/ath/ath10k/hw.h | 14 ++----------- >> drivers/net/wireless/ath/ath10k/pci.c | 10 ++++----- >> drivers/net/wireless/ath/ath10k/targaddrs.h | 3 +++ >> 4 files changed, 14 insertions(+), 45 deletions(-) >> --- >> base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 >> change-id: 20240129-wcn3990-board-fw-a2d97507a712 > > Kalle, Jeff, is there anything pending on me on this series? > Nothing from me -- this is outside my area of expertise so I'm deferring to Kalle. Kalle?