Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2622552lqz; Wed, 3 Apr 2024 03:57:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOkVSUO5xROmZO67kfao75Tc20zsYSK0T9oBDbCfFFL9XiFqfb/tf/iViAU0Q9t+kQ484CX5qtdRC/3ShPSLsi3elFKHEfTFvu80puqA== X-Google-Smtp-Source: AGHT+IHv8qC1ZiEfPX0GA0FwgujBfXvEo7FEWG+VKsaVvNaS22+6NPda6FeG2nMU7//Mt4BmfZvP X-Received: by 2002:a17:906:6a0b:b0:a4e:2c84:6424 with SMTP id qw11-20020a1709066a0b00b00a4e2c846424mr12628161ejc.56.1712141842230; Wed, 03 Apr 2024 03:57:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712141842; cv=pass; d=google.com; s=arc-20160816; b=G/n+bnq79UK3UfhM6XXKUcAJ4FmOwI2kpFuLWnP2Jk44BrdaHVb9FDL0omdlpCW500 Ogluf0bS9VpTevzwC6qLTJgW8O/61KeVM8jFg6DHn5/8zUM0dzF378ELJwNGnjE//UiX XX+u+xasht3nR/3HLPf8wboRLuh8qrZTfxCuFwdjSSHtjRkRovIa6Ty4nrSdtLf2e+Ad YbRmZBjJzgTK6AMBVMzjD2KIdg/LNtxRCLKBF7UHmEjeNTiKNyV0s5eRhZ01b8RK1o5v LNDZnFyxGcVJEmfbemdRRC99nl5P7CVtBQeZrCkViRlIl079ijFL8RXBIa75BJTSRDsv Vaeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=DG8RRYGurHH7eJqvVVi62aX25pa8rpEUy+z3d66HOPc=; fh=YgckwT2SxDlyQ4GOv8OA89xCEiTlnxE1uUyvS/b4v+0=; b=t2AaxOd/WSw4aiApTY8tZpe2dJNkNkqNZyxxZQ7Wdvfqr6rYjdQLVpY/uxc8UNf7hR axFdQB6Le+H0/KhqHJwpFp9dWO0EYUBw0H/7BwOIh3FgTRDfas3w5IjWZksl3GyCmCO2 Vg9HggSsmaiHVJnXrn8xR4URw9hXNkvA79PjvgWj20mXnJEAsFhZhBi5SXoDIRuOmTMm +nZVaX+BAFuhY5r4JPJKm18+qGvS1Bnd06HZnQrtBk9e3qk/0Z4I4p9+eFlc9Qplcm5r wP6lCIJvRDIvNyK4/k3I51bsMax3nA5CPgDDHzsD+grH3h+7Xi+D4bGe+8ZX6w6kA0K0 v17w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=DIsV3Peg; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-wireless+bounces-5811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5811-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id t25-20020a17090616d900b00a473072a5a0si6372217ejd.7.2024.04.03.03.57.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 03:57:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=DIsV3Peg; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-wireless+bounces-5811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5811-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2CE0E1F29ADC for ; Wed, 3 Apr 2024 10:56:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F1F97317F; Wed, 3 Apr 2024 10:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="DIsV3Peg" X-Original-To: linux-wireless@vger.kernel.org Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14BB4136989 for ; Wed, 3 Apr 2024 10:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712141773; cv=none; b=BzuCnvqI49wtNlmqtYBFTANU/BzpHB0i10J9WZYGAjTR9HmWdz5dRUaNNUpskGPXX/3vdBTzeS0o9w5Bu3Sz4KwOCErrCS2QSJxNkHMXq9qUaRR9ieNAziMUMoRQhZub+rUgBQZc/S8IWeIYNOv2pKp1SAuIZomxLR8pjRt30II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712141773; c=relaxed/simple; bh=Vojos7bBxegOeHnGrc2X27ECUOk5DuwcDgpY2noBjhg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cqgFw973mb3X/B/kutKoxoXIeDBsEx+1f8S28qj+qxCE75HjcUJu5SuNle0v/e36V1o8y5gdFWcfNmA4pI+iwurLMgxQO02n6+Y4fKpHdZ0QWCLb7L1EzU5dMi86WiiKLQ9znBDK93VP+MZDKsCOw3xMTKm1lIypd71fHGsQ7/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=DIsV3Peg; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DG8RRYGurHH7eJqvVVi62aX25pa8rpEUy+z3d66HOPc=; b=DIsV3PegxvRrMFBV4MQWfctgr1 hGROqOBEVGurOe08vyHQXQSZHe9jF0J3ZA5K5nHnU4VZDP/6xwjsyzkKFCUpapqV+3Sq+oBJYilhm dL5x6+6bRKs74rANpFUQZw4ckzAiUVXZSNbKa6h1QKBniUiTfjDJ4grt/c39idV4TO0c=; Received: from p54ae9c93.dip0.t-ipconnect.de ([84.174.156.147] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rryHp-00ChNS-C4; Wed, 03 Apr 2024 12:56:09 +0200 Message-ID: Date: Wed, 3 Apr 2024 12:56:08 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] wifi: mt76: mt7996: let upper layer handle MGMT frame protection To: Shayne Chen Cc: linux-wireless , Lorenzo Bianconi , Ryder Lee , Evelyn Tsai , Bo Jiao , linux-mediatek , Michael-CY Lee References: <20240320110918.3488-1-shayne.chen@mediatek.com> <20240320110918.3488-9-shayne.chen@mediatek.com> From: Felix Fietkau Content-Language: en-US Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <20240320110918.3488-9-shayne.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.03.24 12:09, Shayne Chen wrote: > From: Michael-CY Lee > > The firmware support for management frame protection has limitations: > - do not support cipher BIP-GMAC-128 and BIP-GMAC-256 > - support cipher BIP-CMAC-128 and BIP-CMAC-256, except action frame with > action type 'not robust'. > > Therefore, to simplify the logic, do not set the IGTK to firmware and > let the encryption of management frames be handled by upper layer. > > Signed-off-by: Michael-CY Lee > Signed-off-by: Shayne Chen > --- > drivers/net/wireless/mediatek/mt76/mt7996/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c > index 338ff10b121d..4ab4d2bcbedc 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c > @@ -352,10 +352,6 @@ static int mt7996_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, > > /* fall back to sw encryption for unsupported ciphers */ > switch (key->cipher) { > - case WLAN_CIPHER_SUITE_AES_CMAC: > - wcid_keyidx = &wcid->hw_key_idx2; Did you intend to drop the wcid_keyidx line? If so, I don't see anything related to that in the patch description. - Felix