Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2629160lqz; Wed, 3 Apr 2024 04:09:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHir0gi9uRfGIy0SRBydGU/dGTzgzCYgZGbog33k8QwmiguWeccuDGdeotoWfzB6uVWcrKrBwvCeCVf71P2rzIGHNpShiAKSn1eKrTqA== X-Google-Smtp-Source: AGHT+IGSn7OCSHxspaD1Cy5Acf0C+20cMZWSfQK4hT4Kz8RR5/S0IjNS4OW+wJ0ruwBpIofGxhYw X-Received: by 2002:a05:6870:55c6:b0:22a:4b19:64 with SMTP id qk6-20020a05687055c600b0022a4b190064mr2620690oac.16.1712142541913; Wed, 03 Apr 2024 04:09:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712142541; cv=pass; d=google.com; s=arc-20160816; b=KLrfcjEHolENo38yXow/cZhThlHzIukNk5wVdHqMwFWPcGOOBL7PSTR6vJZqhEzFuo G5XSQT35JUEBNwgDt/GoS5/43ifxMlbieXf/Nd7k/96WJZjIyK6Y8T8OqYTyYtzAO3sp l2xexioSqytTFfjzlnaWaYaL8pM/iVsIPNt/j+tCidhs1pxBj9ru9YlAlv3eyoSxjR5d aYZz+3nYEpx3+OOS1pcjdl6hQSWhlUeRdeJNR+BdQgn8d8vyehQViNASDR/BXUcIAMi+ 8ZaNWboY2wISQPVZGMQm2Kved9jX+g4acCD3AAX7OQ9v6POh+IG314qJeQSHXsuV1nuS /a+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=BQXR41AesZLRM9jJK9HfvouXViEHlO7QApiKUi7YnH8=; fh=3lH/BYcHC65O0pFXar86kiVk9ANZkzQZ+bLpIMPqwpw=; b=JOqGy5UPxfBOKsCNevxqI0AfJ7mMeukOCjuQXKVsiVsXFo0ldiaFEfVYa4ryIGUJdD kslxx1JfQqRwG7S0DT328rxuafxj0fMhiF5wY2kMX4pkTBz2oc1PVm9h2tNneoimi9Sf HDXdE28FmxCkzg59QJgHS88brEelXpasJcPGxMW0AKHf59hz55uoalBNF0Am6dJTz8pN S9xtLjzNK5cziVLF0Yrw/FNvhG9VjSpwtZfdZD2Ls7YC463SndX5CTPO/UZuk9zG60RT DeKEniIARi0FkSIGgjd9EcUYvArsJ7Bq2AuDAHVJbB7CxbjxX79uF42A4+XFDQTCM8Nh KR6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=bTDXjEyo; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-wireless+bounces-5812-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5812-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h11-20020a056a00000b00b006e6cc8f90f5si12510406pfk.274.2024.04.03.04.09.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 04:09:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5812-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=bTDXjEyo; arc=pass (i=1 dkim=pass dkdomain=nbd.name dmarc=pass fromdomain=nbd.name); spf=pass (google.com: domain of linux-wireless+bounces-5812-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5812-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nbd.name Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6DCB928F961 for ; Wed, 3 Apr 2024 10:58:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1463D13665F; Wed, 3 Apr 2024 10:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="bTDXjEyo" X-Original-To: linux-wireless@vger.kernel.org Received: from nbd.name (nbd.name [46.4.11.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68EE81353E2 for ; Wed, 3 Apr 2024 10:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.4.11.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712141841; cv=none; b=JkKNWeuhvfuBjKNogDNmwn0O4UKoEfcfm/ViqMF2nMqEsZ4s5x+q3zzgzQ9hWMr51xAjSj3FMefoM/j3hKyFB+74BflMDgieIsqFrWsqpB39fH2VgvYCx4DEXQFOQCZ6Ve9hST/gOK8TK7cCJQq0wWGw99V+UYP/ELtqn364wtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712141841; c=relaxed/simple; bh=fi7cOj43Zr5QeOscWvQGsjRkY9QsQwAscxWYSCpgl1o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=robaEUi+qZwy5P+gGRS89um/VcL734/gLVOIe3eRWDSM0OC5p5LOyyuVOHfaLTkqj8U2A4yQ07oiWzSZF9ZlkzUvju125ndo8VUc0VO1z7bRZGdWgB1ZW+O57CpFA00H9AZFM1ckVAhUdJAO/1cMmg3jz5wDNiEICp1vJ+F7qWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name; spf=none smtp.mailfrom=nbd.name; dkim=pass (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b=bTDXjEyo; arc=none smtp.client-ip=46.4.11.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nbd.name Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nbd.name DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQXR41AesZLRM9jJK9HfvouXViEHlO7QApiKUi7YnH8=; b=bTDXjEyoY+y8PaUrVRaxFAYlQr 8Oq+GBbd+HL/pv9JzCteYfuBqahIsiGs8uGqUyapTqKliHWpf2eT75ABfy0GAdQrTfBk+RzruqpHc re4PKlLkQcwtN+rcCRgu3NczJMRE9QTjnHY4EswJGonROkX1I7yVyuYIfaQz0Mjwi1nA=; Received: from p54ae9c93.dip0.t-ipconnect.de ([84.174.156.147] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rryIt-00ChQx-Ja; Wed, 03 Apr 2024 12:57:15 +0200 Message-ID: <8fe81cdf-5807-4d6b-9bad-7a45208cd15a@nbd.name> Date: Wed, 3 Apr 2024 12:57:15 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] wifi: mt76: mt7996: add sanity check for NAPI schedule To: Shayne Chen Cc: linux-wireless , Lorenzo Bianconi , Ryder Lee , Evelyn Tsai , Bo Jiao , linux-mediatek , Henry Yen References: <20240320110918.3488-1-shayne.chen@mediatek.com> <20240320110918.3488-10-shayne.chen@mediatek.com> Content-Language: en-US From: Felix Fietkau Autocrypt: addr=nbd@nbd.name; keydata= xsDiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwc0cRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPsJgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQzsFNBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabwkkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCeMncXpbbWNT2AtoAYICrKyX5R3iMAoMhw cL98efvrjdstUfTCP2pfetyN In-Reply-To: <20240320110918.3488-10-shayne.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.03.24 12:09, Shayne Chen wrote: > From: Henry Yen > > It's observed that host driver might occasionally receive > interrupts from unexpected Rx ring, whose Rx NAPI hasn't been > prepared yet. Under such situation, __napi_poll crash issue > would occur, so we add a sanity check to prevent it. > > Without this patch, we might encounter kernel crash issue > especially in WED-on & RRO-on software path. Does this issue occur even with Lorenzo's fix "wifi: mt76: mt7996: fix uninitialized variable in mt7996_irq_tasklet()"? - Felix