Received-SPF: pass (google.com: domain of linux-wireless+bounces-5848-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <4ff8db98-3389-4fe1-9cc1-0880d4d6cc22@quicinc.com>
Date: Wed, 3 Apr 2024 11:17:26 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 9/9] wifi: ath12k: skip sending vdev down for channel
 switch
Content-Language: en-US
To: Aloka Dixit <quic_alokad@quicinc.com>, <ath12k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>
References: <20240402210538.7308-1-quic_alokad@quicinc.com>
 <20240402210538.7308-10-quic_alokad@quicinc.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240402210538.7308-10-quic_alokad@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 4/2/2024 2:05 PM, Aloka Dixit wrote:
> Remove the unnecessary WMI vdev down operation as firmware
> internally does so already as part of WMI vdev restart.
> Repeated vdev down results in a firmware crash during channel
> switch operation when multiple BSSID advertisements are enabled:
> ath12k_pci 0000:06:00.0: firmware crashed: MHI_CB_SYS_ERROR
> ath12k_pci 0000:06:00.0: failed to send WMI_VDEV_SET_PARAM_CMDID
> ath12k_pci 0000:06:00.0: failed to set vdev 5 HE MU mode: -108 param_value 7b
> ath12k_pci 0000:06:00.0: failed to set he mode vdev 5
> ath12k_pci 0000:06:00.0: failed to restart vdev 5: -108
> ath12k_pci 0000:06:00.0: failed to send WMI_VDEV_SET_PARAM_CMDID
> ath12k_pci 0000:06:00.0: failed to set vdev 4 HE MU mode: -108 param_value 7b
> ath12k_pci 0000:06:00.0: failed to set he mode vdev 4
> ath12k_pci 0000:06:00.0: failed to restart vdev 4: -108
> ath12k_pci 0000:06:00.0: failed to send WMI_VDEV_SET_PARAM_CMDID
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>