Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2983294lqz; Wed, 3 Apr 2024 14:33:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXHPsjRMvSugatQuRwsbpalZSXg+w+exFW1OsXoeVmYZhDkE5pNslJdn771LO2QkaO6F0QVhJ7JALpVSTXpzQDH0c8Udh+Ylzj67dK7Tg== X-Google-Smtp-Source: AGHT+IEc8xv3BON1MsVa4dIXLyCcTWKTSqpdJ8tW1MUvm//t7jhKxc/qshvlihq5WPQTQSBUYVwe X-Received: by 2002:a17:903:41cc:b0:1e2:8832:1d2c with SMTP id u12-20020a17090341cc00b001e288321d2cmr702013ple.27.1712180028087; Wed, 03 Apr 2024 14:33:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712180028; cv=pass; d=google.com; s=arc-20160816; b=FIncNa7vTjjMEAiZsg5YMKphQ3jctpbUK6PoXKC/b49KPZ6FWwK2NvrB0wAFSr4TdB gK/9edtlALzFtMui5b1CUfJGu/rpNDvv4HMyA/kWWudpZ5vAPcLwVRiHMM6m8YpvNXnL kwx6SbxQZob+RKTrOU6ATJOENMwaTuBPpGYDqjTOWqMKuGaNH8gFTtV3RkhU3Ovxlb9i tfoK5XkUj/WSvIHKrdWDeG/yIrnzYHn9MCNvnPjbFjx1VSw8m911Knx7FZ5YKFb3bEzd 0ujX7d7NoZUkITlH27h/65rhbGn5lb5lEvds+09ZmuIpUrzRNzeLV5iPrTgkOyZ6J7jt afUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=zKcfJEWPy8TF6EjCWJ8BJL0m/4Wc3HUSGtpaiggXuiI=; fh=+cvayaNQ+hGV2beN/1N3hPxWzM0kan7ClrBcqfgEKKI=; b=OV2gJaVCAFhAj2buumcnf1xMCAyjj8elCmlU7TIqvmCI4ewVKYyT6L2G78jTc6cahJ EyzD8qvahvTuvKJN7wVbU3qamt0q50JeIJ3WHlcoyaAW1AJN2mqdTjFA7/ZSM1vuFxgS HlyhGpEJ3h4U7BugyYzmxz+2iS0Z8NKaTGTjmNcV82bM5M8rOikrTlGmCRq7R1xrTKoj lh2Z/wgzKVlp3oi0LnRU9tHNK/vgP5Ash1Oskl2ePlOFK03iuGlQmAJa2U648MNd6ykk viyixl9OVkd1u8hkqhs3zgh1fLJzhVMtEKjb60/J9rF3XqURgQZzL8o4353pzn0ubYqT n40A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=aqkX3Oh5; arc=pass (i=1 spf=pass spfdomain=toke.dk dkim=pass dkdomain=toke.dk dmarc=pass fromdomain=toke.dk); spf=pass (google.com: domain of linux-wireless+bounces-5853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id k10-20020a170902d58a00b001e0afc34ae1si14380710plh.40.2024.04.03.14.33.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 14:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=aqkX3Oh5; arc=pass (i=1 spf=pass spfdomain=toke.dk dkim=pass dkdomain=toke.dk dmarc=pass fromdomain=toke.dk); spf=pass (google.com: domain of linux-wireless+bounces-5853-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5853-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D566AB25680 for ; Wed, 3 Apr 2024 21:23:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9172E15664D; Wed, 3 Apr 2024 21:23:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="aqkX3Oh5" X-Original-To: linux-wireless@vger.kernel.org Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F15AB2C683; Wed, 3 Apr 2024 21:23:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.145.95.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712179404; cv=none; b=Xrpt8nfBstkSz7Eg2pJWS8aOUXEFKLoucoR/VMYsLtXF7Tiu2TFbgfezHHumotlLjkjGQdiC8LVku9beZxvQOypG3REKf/1wZ7xK/Rlf9i14LqEqUcGFi2ziTrIUiWeEf9jtAk+UFgHNc4jKqSjwjjUi9hzFMuns4MKerND2JyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712179404; c=relaxed/simple; bh=zKcfJEWPy8TF6EjCWJ8BJL0m/4Wc3HUSGtpaiggXuiI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JECmoHCpMay2ThjuYCYCikpwcHTEeH3juyIdT3zVR0c6reYY1Lo+NJnXabzvFoy+BI7CzhGUsSajxjiVMKJEjzSm/Qu2c6ABE7skSmvsbPmJOI2lJUyblMSiXcWgx/9Q+MmK0XbKIGr4dZOcwDZwNWodpjEiOPdk1yHSVqwL5r8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk; spf=pass smtp.mailfrom=toke.dk; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b=aqkX3Oh5; arc=none smtp.client-ip=45.145.95.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toke.dk From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1712179389; bh=zKcfJEWPy8TF6EjCWJ8BJL0m/4Wc3HUSGtpaiggXuiI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aqkX3Oh5oUQ9Pj917Fpw6OxxRrxAvxIwZNg6WEu/GatO06cG1Rbj2M4W1knXjL/I9 WbYkGl9CfL4FZ5UKL4ouYaD2WSk/coLw1TN7CmGCKayWuFLDo5coaPWpMBSauRCA52 vRGBN4nUU/9Z4FiylTkv9jF53Dx4pGaGLEOIAzzhwmmR3RkSMWOBpROyM9vsplJKJz knPyqjQjZAJjoD+K1JYQr6dDRxuXqBNK43pPU+Q1VAsaWXWTRTXmZy2udmTTyqKoZP oAwrMisu1sWEZWpbtqYG1fkRKj6P2MIzsm7v5LmzY9sbQe/1V1JTpQ7bRv/1ds1L59 yTHTawT+o9WCQ== To: Heiner Kallweit , Kalle Valo , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Martin Blumenstingl Cc: linux-wireless , "linux-arm-kernel@lists.infradead.org" , linux-actions@lists.infradead.org, "linux-pci@vger.kernel.org" Subject: Re: [PATCH] ath9k: use unmanaged PCI functions in ath9k_pci_owl_loader In-Reply-To: References: Date: Wed, 03 Apr 2024 23:23:08 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87y19ukuo3.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Heiner Kallweit writes: > Using the device-managed versions has no benefit here, because > resources are released as part of the asynchronous fw loading. > > Actual reason why I got here is that I was looking for places with > dubious use of pcim_pin_device(). Could you please expand the commit message to explain what this means in a bit more detail? That will be helpful to someone who wants to understand what the difference between these versions is and why this change makes sense, but who is not that familiar with how these internal bits are really supposed to work. Someone like myself, in other words :) -Toke