Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp168444lqe; Thu, 4 Apr 2024 03:13:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUyC6KAtfJ3bLePXHhg+GZbd3BCqwHo50bVZk4WUQdHVabXheHtO4Cuw0PTvJQzgPN049KAk3ZlDpNFJB02adLggI9oY4uHJeFEodGF2A== X-Google-Smtp-Source: AGHT+IHxA3xUSRvsU7I9AUwpJX5v+QQqZFhvfAm3WrmMAXKq6xzgUvXKOtavkLHoTCYIWI1ph08I X-Received: by 2002:a05:6870:1588:b0:22e:b3c6:96cf with SMTP id j8-20020a056870158800b0022eb3c696cfmr1512392oab.49.1712225603973; Thu, 04 Apr 2024 03:13:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712225603; cv=pass; d=google.com; s=arc-20160816; b=hrkE+YY+cUFu+94KkRRiBRa+w0waXcpwxb8jJKg52CLywuX7UB0iOiZd/bCIVO8OYo uSzqfs/f6nLvcidYu2o840U3VLucFJQ42yxXosuWhIbdboM2i4Dynm5ozF7h+kYg9O15 kseJ9fHA9Vtl2eIIBKhAAsLxByU5uySrCyqfOwfZ3sVhva9EIzdmF5kJvJ172rt00NJW iozGv8gN5X19og1B7X8JIjRxBGjwOBjzHMgVmubu+LClrNF1SMehgJaRbBr1iTYe2Eut 0JMUtIPUHFgT5lKZ+dhzDmkVF5eD+LfdnFx6hJaWN0pjJw+bIvYLJA3feZKYirLRTVJ8 AMLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Kf5fdQAo8a5tkr3LVDPMevxX+JPfaHoeszYBlngAvXA=; fh=6YTvTa/aqGYXvMb5pASkP0T7xTr1D72ljhVkbhQsqQg=; b=T8K/Ap/zOEZExmLp4QBtckZ2nhWvoz9+uie2S10YXfagdXEjvXz9ZPWK2REwbjzfob Ir3zaY9TL5bNzJOWh3D9bsIBOAORXZoJ4StwmbEOLTaIg2Z6sfZQTWQuKWolsxwAVcNq RhfjlGujhv3SAJH/iwnqzMM0lnrAzTzDZ6dQL/FaJULF4Eiuv6TRVWtHEdd3gmiH0qLf d9U1w5rcJu5fkdmwTwA0M/AAbOXkHjx29aM448yiWSNUT8XssBcAEjgJ/XsjR7P07xR6 HqXip3oYDCI9V1eUMEQs5+rmSQMohl6Nh+YPbS5xZB4ICoEiQ/jY5OyM9ifU8vDhmNec ShGg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MfDQu68w; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y7-20020aa793c7000000b006ea7e52efe8si14816325pff.384.2024.04.04.03.13.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:13:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MfDQu68w; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5866-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EEC0A287D3B for ; Thu, 4 Apr 2024 10:13:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C2CB475805; Thu, 4 Apr 2024 10:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MfDQu68w" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B292757F3; Thu, 4 Apr 2024 10:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225590; cv=none; b=JlzspX1Mze5aaLXc4mopIjJ3FdvBWrKiQBmyOWd1XX2R8/5z0gxQgFTs1kFSU38Y+eEtZsCuSeWaTY6JtSFqlwWcA12oyQxK9zkS6uKyj29FO3r0PclM5GALThQWca7idvxWLXL0BHrQ5a+2Fr282Jx3nZeHgONmztsaQxL+RvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225590; c=relaxed/simple; bh=ov/eEmo4hI8DNy7UxuewIgS81uubOwPI939mMAuO5Sk=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=CmsHOLG7MF4kVJ1tGuDwFJvQqePR5vBUfv6DtKT0GpdIgVEN1paqMQvsvOpB62I8R7kbyAEw+n14QGXxCEyGJBnMYm0XIEc1TI12yqlA5MCe4NlI/FXnLqB57nUPaog6HuNQks97N+FXRDf9nP3g8/4OwYOZBRXTdgEiN7vKc80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MfDQu68w; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28935C433C7; Thu, 4 Apr 2024 10:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712225590; bh=ov/eEmo4hI8DNy7UxuewIgS81uubOwPI939mMAuO5Sk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=MfDQu68wdj0+Gt+hGh32IxxTl+2WxdimEZwggEOKt4TcerYqgIs/eEf1y6z++L3NR Nodp/ttcxthuQywCuam2suW5SiThDG1zKQBP+68eojlP7PLA77Gy9zrjVHLGWHVxqQ 4W/vQbgCin/d6bjG2gkHD/bBnyRZ1HOcEpfb1xOhJGvciXiuUxqtfl7BlfqjR0Xihf XQ75LqUJrRxN6K9kZ3nu9ud4+y/264FVfhgJY/Vmcn1RMBY1MxgT9ytWDn0k7ZzJn0 tiRhyaaaQSUFklVMUIQnjSpUC2a+wuFlgmROOtCEEwSq6uj5B03jX4lBYURxCoDzbp 5XDjn3h1DlZ9w== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 2/6] wifi: ath6kl: sdio: simplify module initialization From: Kalle Valo In-Reply-To: <20240329171019.63836-2-krzysztof.kozlowski@linaro.org> References: <20240329171019.63836-2-krzysztof.kozlowski@linaro.org> To: Krzysztof Kozlowski Cc: Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171222558545.1806092.4218541650720633810.kvalo@kernel.org> Date: Thu, 4 Apr 2024 10:13:07 +0000 (UTC) Krzysztof Kozlowski wrote: > This driver's initialization functions do not perform any custom code, > except printing messages. Printing messages on modules > loading/unloading is discouraged because it pollutes the dmesg > regardless whether user actually has this device. Core kernel code > already gives tools to investigate whether module was loaded or not. > > Drop the printing messages which allows to replace open-coded > module_sdio_driver(). > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 565759ce814a wifi: ath6kl: sdio: simplify module initialization -- https://patchwork.kernel.org/project/linux-wireless/patch/20240329171019.63836-2-krzysztof.kozlowski@linaro.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches