Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp217702lqe; Thu, 4 Apr 2024 04:58:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXPbqzBS4jNhV/BTSZHdYoVnrvsO2KxbPJHhOOCcVofTBH0cwuSyjMWHQYfdosJfpP1DrFZPK+44hqZEDasD6o4Ah5JjLyDUqN/Rbiw9g== X-Google-Smtp-Source: AGHT+IGfWKSMoai2x8+xMhrSEPzSuoC6SfjDcBgI/PtEs1pdhc5yq5dozHnc3MMtfW3I97AJkGpV X-Received: by 2002:a05:6214:48e:b0:699:2674:929e with SMTP id pt14-20020a056214048e00b006992674929emr1900935qvb.10.1712231895500; Thu, 04 Apr 2024 04:58:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712231895; cv=pass; d=google.com; s=arc-20160816; b=SbxCk9FBLWwweE0Kk9158spDxo8lNpB+XLipIJSklpMaVAp3eOJSqZuCXlG8x6Cxp2 28G8twI3MWq+t8priMiBibYONd7sFuQ68mpvX3xj3EV34lVJO1XEMXE2A/eYrydlOM0g kGOP0Lvh+nXRmyXr7FfCEW1UQMhQCrfBV6gC40HGN3X5JqBeMJG68Xs8iNU9NEH0sDIE KwMhAypXBpelhH4JLNwP/06AmrE4IZN9q5kVFboaAFph6kz95fNT90dmsJUaxaJyEKGZ Mc+ez25SqY6Ok3aDxRvJ5Qx9kMSz6fqwT8AtFaPQzqE61TDlvC1xNR3JdaHK40Yaq6ok b4oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=yZvwwuffk4C6vYsqh7OWkc/SEkgm20qcGxPxeQ+jE7U=; fh=XYUUThUIwxsUnRIU1XDNeYig0UYfnibSKs20IqAmGzY=; b=sUb5/sLt7wcfpAlE3LC+QgXRlPOc5i1deCWiLoEFGP4uyXWqJ0rBkRRg2wkCRoJzaP GB1L5KzfCwv7+6YO1rnXgJVd5tjffd795LIGaDsp7SyCRdOJMEs/rKXECt+ttNZAC3T5 6fPphaplv0unCrBqd7YAZGMjk5CYalBXCIPQzRy5LpMYljYJQOyrUW/1DWvjXz0pKe/0 sNoPjGew91pCXDdnzqVQu2SdsHrtx3nMRlLOfYKp0yWOw7f+LzDp1lsuLxbh0DTOEGPx PNYW3QNFw6qvLBBM4kLpXdCHHRpbR/yOHl6zog1OBfpYc/C+paVTnzpuPqcnQ2784nKX f1Ww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tinh7T1d; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x11-20020a0cfe0b000000b0069693f7b7easi15933898qvr.272.2024.04.04.04.58.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 04:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-5871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tinh7T1d; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-5871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-5871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 927D11C2204D for ; Thu, 4 Apr 2024 11:58:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 862168627B; Thu, 4 Apr 2024 11:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tinh7T1d" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A42084FDB; Thu, 4 Apr 2024 11:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231871; cv=none; b=NjoQNAnp4BJEd/JMWijGm5QCPn485n6eKQ+Ja11PPltoiwIzkAWclVYCGZ89EmPi90dDuJdibmObk6MQwakklp9gOQ4Bwe0ird6iRvBDbiuIB7jl0zvODvWarWcgmF6rTNJJ5/BObxCGkB2Ne9SElQkdpkKmf0TrbreECIDdwTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712231871; c=relaxed/simple; bh=oyPatv7PBt0holfVUYukJP8QPI1R/fKA+cCRZYJIaig=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=q/kI0lYFHM2rEg+IlcnCUpQSvTMU8mekHhUkSiFPYDn04jZ9w5rUaY/5rP/2OTUUb8Xj9g7N+7loXYTUxDH3witr30XJkTOK56sD7jjh4feqrQz5vF1hVd6OnzJZ3A+017dL/ietnzgQ+EIEO8oAkgPA71QhSQVDS141etgQseo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tinh7T1d; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77253C43394; Thu, 4 Apr 2024 11:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712231871; bh=oyPatv7PBt0holfVUYukJP8QPI1R/fKA+cCRZYJIaig=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Tinh7T1dpbBAZFIvgHQsGQjt/0I1nrX4iqfeXu6jrWUyo0+9kaF8XGmmZlRy6aOC5 Zmwd/1oVr0T/Kg9Nn2oSMiHafCk4mhUXyd+luoCFjq467AEyDpYcK7iDtXUsPiNuNL 8Xw+aNrCE0jUfDUCFdk9Khq/JW4SGqYWP57ZJNTi9Qr4RCiTJ+CzRlcDK20UGnTwSS ob3QmPFqAUTKh2ettqurQvj4LdISg/4YfTfbTQ5wR0iOc4KfVCYkZ4gU1yVcKBDI9G XXN/KsC5vZ7EEiMcW5YxK64qwoTJsXGt87SloFje7xCrntHwidNNeOyVbXW1njOb1D yMiaOE4OIyNbQ== From: Kalle Valo To: Dmitry Baryshkov Cc: Marc Gonzalez , Konrad Dybcio , Krzysztof Kozlowski , Jeff Johnson , ath10k , wireless , DT , MSM , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pierre-Hugues Husson , Arnaud Vrac , Bjorn Andersson , Jami Kettunen , Jeffrey Hugo Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi References: <5cdad89c-282a-4df5-a286-b8404bc4dd81@freebox.fr> <252618e8-9e80-4774-a96c-caa7f838ef01@linaro.org> <502322f1-4f66-4922-bc4e-46bacac23410@linaro.org> <0ca1221b-b707-450f-877d-ca07a601624d@freebox.fr> Date: Thu, 04 Apr 2024 14:57:45 +0300 In-Reply-To: (Dmitry Baryshkov's message of "Tue, 2 Apr 2024 18:55:56 +0300") Message-ID: <87ttkh49xi.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: >> 3) ADD that compatible to the wifi node in msm8998.dtsi >> compatible = "qcom,wcn3990-wifi", "qcom,msm8998-wifi"; >> 4) In the driver, set qmi->fake_msa_ready_indicator to true if we >> detect "qcom,msm8998-wifi" >> >> And this approach would be acceptable to both ath10k & DT maintainers? > > I'd say, we should take a step back and actually verify how this was > handled in the vendor kernel. One comment related to this: usually vendor driver and firmware branches go "hand in hand", meaning that a version of driver supports only one specific firmware branch. And there can be a lot of branches. So even if one branch might have a check for something specific, there are no guarantees what the other N+1 branches do :/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches