Received-SPF: pass (google.com: domain of linux-wireless+bounces-5884-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <65e994e1-8da9-470f-9b1e-b2db20974b2d@quicinc.com>
Date: Fri, 5 Apr 2024 07:42:31 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 00/12] wifi: ath12k: Add single wiphy suppor
From: Rameshkumar Sundaram <quic_ramess@quicinc.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, <ath12k@lists.infradead.org>
CC: <linux-wireless@vger.kernel.org>, Sriram R <quic_srirrama@quicinc.com>
References: <20240401190409.2461819-1-quic_ramess@quicinc.com>
 <0d1058eb-aced-4e81-9f61-e4b5a08c04a2@quicinc.com>
 <bdf7abad-3d13-4085-8e75-c0d5ff4b41db@quicinc.com>
Content-Language: en-US
In-Reply-To: <bdf7abad-3d13-4085-8e75-c0d5ff4b41db@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 4/2/2024 3:36 PM, Rameshkumar Sundaram wrote:
> 
> 
> On 4/2/2024 1:04 AM, Jeff Johnson wrote:
>> On 4/1/2024 12:03 PM, Rameshkumar Sundaram wrote:
>>> From: Sriram R <quic_srirrama@quicinc.com>
>>>
>>> With the introduction of Multi Link Operation (MLO) support in
>>> IEEE802.11be, each EHT AP/non AP interface is capable of
>>> operating with multiple radio links.
>>>
>>> cfg80211/mac80211 expects drivers to abstract the communication
>>> between such Multi Link HW and mac80211/cfg80211 since it depends
>>> on different driver/HW implementation. Hence the single wiphy
>>> abstraction with changes in datastructures were introduced in
>>> "wifi: ath12k: Introduce hw abstraction"
>>>
>>> This patchset extends the implementation to allow combination
>>> of multiple underlying radios into a single composite hw/wiphy
>>> for registration. Since now multiple radios are represented by
>>> a single wiphy, changes are required in various mac ops that the
>>> driver supports since the driver now needs to learn on how to tunnel
>>> various mac ops properly to a specific radio.
>>>
>>> This patchset covers the basic mac80211 ops for an interface bring up
>>> and operation.
>>>
>>> Note:
>>> Monitor and hw reconfig support for Single Wiphy will be done in future
>>> patchsets.
>>
>> thinking about this series in the context of some other patches I've been
>> reviewing recently, I don't think this series should be talking about
>> supporting multiple radios with a single wiphy, but instead about 
>> supporting
>> multiple devices with a single wiphy. After all, the existing logic 
>> already
>> supports a single device with multiple radios, so it isn't the 
>> multitude of
>> radios that is the issue, it is the multitude of devices.
> So far we are only combining radios of a device (ab) and registering it 
> as single HW(ah) to mac80211. Currently ah will only contain radios of 
> one device. Combining multiple devices into a single HW is different 
> series (where ag will be introduced).
> 
> Having said that, even if multiple devices are combined with ag, at hw 
> (ah) level there are only radios of multiple devices (ab) and hence 
> these patches stay generic and call them as radios.
>>
>> this would have ramifications on many of the commit messages in this 
>> series.
>>
> 
Hi Jeff,
Planning to re-spin v7 to address comments on PATCH 07/12, do you have 
anymore comments on the commit text or other patches ?