Received-SPF: pass (google.com: domain of linux-wireless+bounces-5958-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d409c77b-f4fa-4c12-9467-1a9916f697ef@quicinc.com>
Date: Sun, 7 Apr 2024 11:29:00 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] wifi: ar5523: enable proper endpoint verification
Content-Language: en-US
To: Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
        Kalle Valo
	<kvalo@kernel.org>
CC: Wu Yunchuan <yunchuan@nfschina.com>,
        Johannes Berg
	<johannes.berg@intel.com>,
        Breno Leitao <leitao@debian.org>, <linux-wireless@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>,
        <syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com>
References: <20240407150534.26737-1-n.zhandarovich@fintech.ru>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <20240407150534.26737-1-n.zhandarovich@fintech.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 4/7/2024 8:05 AM, Nikita Zhandarovich wrote:
[...]
> diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c b/drivers/net/wireless/ath/ar5523/ar5523.c
> index 815f8f599f5d..5cac4a6452db 100644
> --- a/drivers/net/wireless/ath/ar5523/ar5523.c
> +++ b/drivers/net/wireless/ath/ar5523/ar5523.c
> @@ -1594,6 +1594,20 @@ static int ar5523_probe(struct usb_interface *intf,
>  	struct ar5523 *ar;
>  	int error = -ENOMEM;
>  
> +	static u8 bulk_ep_addr[] = {

add 'const' qualifier

> +		AR5523_CMD_TX_PIPE | USB_DIR_OUT,
> +		AR5523_DATA_TX_PIPE | USB_DIR_OUT,
> +		AR5523_CMD_RX_PIPE | USB_DIR_IN,
> +		AR5523_DATA_RX_PIPE | USB_DIR_IN,
> +		0};
> +
> +	if (!usb_check_bulk_endpoints(intf, bulk_ep_addr)) {
> +		dev_err(&dev->dev,
> +			"Could not find all expected endpoints\n");
> +		error = -ENODEV;
> +		goto out;
> +	}
> +
>  	/*
>  	 * Load firmware if the device requires it.  This will return
>  	 * -ENXIO on success and we'll get called back afer the usb
>