Received-SPF: pass (google.com: domain of linux-wireless+bounces-5976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <bae1e71edcc13e73e8ef7f24d30140a4a6aefb98.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: handle sdata->u.ap.active flag with MLO
From: Johannes Berg <johannes@sipsolutions.net>
To: Aditya Kumar Singh <quic_adisi@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Mon, 08 Apr 2024 20:25:36 +0200
In-Reply-To: <20240326151141.3824454-1-quic_adisi@quicinc.com>
References: <20240326151141.3824454-1-quic_adisi@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-03-26 at 20:41 +0530, Aditya Kumar Singh wrote:

> @@ -1232,7 +1256,9 @@ ieee80211_assign_beacon(struct ieee80211_sub_if_dat=
a *sdata,
>  	}
> =20
>  	rcu_assign_pointer(link->u.ap.beacon, new);
> -	sdata->u.ap.active =3D true;
> +
> +	if (ieee80211_num_beaconing_links(sdata) <=3D 1)
> +		sdata->u.ap.active =3D true;

I don't understand this change. Neither the <=3D 1 really, nor the fact
that you actually _make_ this change.

> @@ -1486,7 +1488,10 @@ static int ieee80211_start_ap(struct wiphy *wiphy,=
 struct net_device *dev,
>  		if (old)
>  			kfree_rcu(old, rcu_head);
>  		RCU_INIT_POINTER(link->u.ap.beacon, NULL);
> -		sdata->u.ap.active =3D false;
> +
> +		if (!ieee80211_num_beaconing_links(sdata))
> +			sdata->u.ap.active =3D false;

=3D=3D 0 maybe?

Or maybe we should just save/restore the value instead?

>  	list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list)
>  		netif_carrier_off(vlan->dev);
> =20
> -	if (ieee80211_num_beaconing_links(sdata) <=3D 1)

Unrelated, but it looks like the VLAN netif_carrier_off() handling above
is also wrong and should really go into this if block as well.

johannes