Received-SPF: pass (google.com: domain of linux-wireless+bounces-5978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e599d1b1c7c6e32856eb5374cfaa20965b49b44c.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: cfg80211: Clear mlo_links info when STA disconnect
From: Johannes Berg <johannes@sipsolutions.net>
To: Xin Deng <quic_deng@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Mon, 08 Apr 2024 20:41:27 +0200
In-Reply-To: <20240327032448.15098-1-quic_deng@quicinc.com>
References: <20240327032448.15098-1-quic_deng@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-03-26 at 20:24 -0700, Xin Deng wrote:
> wdev->valid_links is not cleared when upper layer disconnect from a
> wdev->AP MLD. It has been observed that this would prevent offchannel
> operations like remain-on-channel which would be needed for user space
> operations with Public Action frame.

I agree that's a problem, we shouldn't leave the valid_links set.

> Signed-off-by: Xin Deng <quic_deng@quicinc.com>
> ---
>  net/wireless/sme.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 82e3ce42206c..86e837f37f8c 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -492,6 +492,7 @@ void cfg80211_wdev_release_link_bsses(struct wireless=
_dev *wdev, u16 link_mask)
>  				 &wdev->links[link].client.current_bss->pub);
>  		wdev->links[link].client.current_bss =3D NULL;
>  	}
> +	wdev->valid_links =3D 0;
>=20

But this is (very obviously, even with only the limited context shown!)
in the completely wrong place.

johannes