Received-SPF: pass (google.com: domain of linux-wireless+bounces-6155-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>,  Jeff
 Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH v2 4/4] wifi: ath12k: Refactor data path cmem init
References: <20240409151415.1226109-1-quic_periyasa@quicinc.com>
	<20240409151415.1226109-5-quic_periyasa@quicinc.com>
Date: Thu, 11 Apr 2024 12:45:54 +0300
In-Reply-To: <20240409151415.1226109-5-quic_periyasa@quicinc.com> (Karthikeyan
	Periyasamy's message of "Tue, 9 Apr 2024 20:44:15 +0530")
Message-ID: <877ch4z0z1.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:

> Move the data path Tx and Rx descriptor primary page table CMEM
> configuration into a helper function. This will make the code more
> scalable for configuring partner device in support of multi-device MLO.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>

[...]

> +static void ath12k_dp_cmem_init(struct ath12k_base *ab,
> +				struct ath12k_dp *dp,
> +				enum ath12k_dp_desc_type type)
> +{
> +	u32 cmem_base;
> +	int i, start, end;
> +
> +	cmem_base = ab->qmi.dev_mem[ATH12K_QMI_DEVMEM_CMEM_INDEX].start;
> +
> +	switch (type) {
> +	case ATH12K_DP_TX_DESC:
> +		start = ATH12K_TX_SPT_PAGE_OFFSET;
> +		end = start + ATH12K_NUM_TX_SPT_PAGES;
> +		break;
> +	case ATH12K_DP_RX_DESC:
> +		start = ATH12K_RX_SPT_PAGE_OFFSET;
> +		end = start + ATH12K_NUM_RX_SPT_PAGES;
> +		break;
> +	default:
> +		ath12k_err(ab, "invalid descriptor type %d in cmem init\n", type);
> +		return;
> +	}
> +
> +	/* Write to PPT in CMEM */
> +	for (i = start; i < end; i++)
> +		ath12k_hif_write32(ab, cmem_base + ATH12K_PPT_ADDR_OFFSET(i),
> +				   dp->spt_info[i].paddr >> ATH12K_SPT_4K_ALIGN_OFFSET);
> +}

Here's a good example why I don't like functions returning void. How do
we handle the errors in this case?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches