Received-SPF: pass (google.com: domain of linux-wireless+bounces-6226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 12 Apr 2024 09:33:55 +0200
Message-Id: <D0HYXSPMY8JE.17YSACO3ROKKZ@gmail.com>
From: "Nicolas Escande" <nico.escande@gmail.com>
To: "kangyang" <quic_kangyang@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: ath12k: add support to handle beacon miss for
 WCN7850
References: <20240412025149.1211-1-quic_kangyang@quicinc.com>
In-Reply-To: <20240412025149.1211-1-quic_kangyang@quicinc.com>

On Fri Apr 12, 2024 at 4:51 AM CEST, kangyang wrote:
[...]
> @@ -5986,6 +6055,20 @@ static int ath12k_mac_vdev_create(struct ath12k *a=
r, struct ieee80211_vif *vif)
>  	lockdep_assert_held(&ar->conf_mutex);
> =20
>  	arvif->ar =3D ar;
> +	arvif->vif =3D vif;
> +
> +	INIT_LIST_HEAD(&arvif->list);
> +	INIT_DELAYED_WORK(&arvif->connection_loss_work,
> +			  ath12k_mac_vif_sta_connection_loss_work);
> +
Is there a need to move the following part ?
Isn't just adding the delay work enough ?
> +	for (i =3D 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> +		arvif->bitrate_mask.control[i].legacy =3D 0xffffffff;
> +		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> +		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> +		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> +		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> +	}
> +
>  	vdev_id =3D __ffs64(ab->free_vdev_map);
>  	arvif->vdev_id =3D vdev_id;
>  	arvif->vdev_subtype =3D WMI_VDEV_SUBTYPE_NONE;
> @@ -6316,16 +6399,6 @@ static int ath12k_mac_op_add_interface(struct ieee=
80211_hw *hw,
> =20
>  	arvif->vif =3D vif;
> =20
> -	INIT_LIST_HEAD(&arvif->list);
> -
> -	for (i =3D 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> -		arvif->bitrate_mask.control[i].legacy =3D 0xffffffff;
> -		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> -		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> -		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> -		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> -	}
> -
>  	/* Allocate Default Queue now and reassign during actual vdev create */
>  	vif->cab_queue =3D ATH12K_HW_DEFAULT_QUEUE;
>  	for (i =3D 0; i < ARRAY_SIZE(vif->hw_queue); i++)
[...]

Thanks