Received-SPF: pass (google.com: domain of linux-wireless+bounces-6234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 12 Apr 2024 11:23:43 +0200
Message-Id: <D0I19V0104BZ.IN8THB2XCFLV@gmail.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: ath12k: add support to handle beacon miss for
 WCN7850
From: "Nicolas Escande" <nico.escande@gmail.com>
To: "Kang Yang" <quic_kangyang@quicinc.com>, <ath12k@lists.infradead.org>
References: <20240412025149.1211-1-quic_kangyang@quicinc.com>
 <D0HYXSPMY8JE.17YSACO3ROKKZ@gmail.com>
 <6ee5664b-997b-45eb-89f9-5f75708c268a@quicinc.com>
In-Reply-To: <6ee5664b-997b-45eb-89f9-5f75708c268a@quicinc.com>

On Fri Apr 12, 2024 at 10:47 AM CEST, Kang Yang wrote:
>
>
> On 4/12/2024 3:33 PM, Nicolas Escande wrote:
> > On Fri Apr 12, 2024 at 4:51 AM CEST, kangyang wrote:
> > [...]
> >> @@ -5986,6 +6055,20 @@ static int ath12k_mac_vdev_create(struct ath12k=
 *ar, struct ieee80211_vif *vif)
> >>   	lockdep_assert_held(&ar->conf_mutex);
> >>  =20
> >>   	arvif->ar =3D ar;
> >> +	arvif->vif =3D vif;
> >> +
> >> +	INIT_LIST_HEAD(&arvif->list);
> >> +	INIT_DELAYED_WORK(&arvif->connection_loss_work,
> >> +			  ath12k_mac_vif_sta_connection_loss_work);
> >> +
> > Is there a need to move the following part ?
> > Isn't just adding the delay work enough ?
>
>
> Just checked, you are right, but should add delay work in add_interface()=
.
>
> Will change in v3.
>
>
> >> +	for (i =3D 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> >> +		arvif->bitrate_mask.control[i].legacy =3D 0xffffffff;
> >> +		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> >> +		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> >> +		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> >> +		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> >> +	}
> >> +
> >>   	vdev_id =3D __ffs64(ab->free_vdev_map);
> >>   	arvif->vdev_id =3D vdev_id;
> >>   	arvif->vdev_subtype =3D WMI_VDEV_SUBTYPE_NONE;
> >> @@ -6316,16 +6399,6 @@ static int ath12k_mac_op_add_interface(struct i=
eee80211_hw *hw,
> >>  =20
> >>   	arvif->vif =3D vif;
> >>  =20
> >> -	INIT_LIST_HEAD(&arvif->list);
> >> -
> >> -	for (i =3D 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> >> -		arvif->bitrate_mask.control[i].legacy =3D 0xffffffff;
> >> -		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> >> -		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> >> -		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> >> -		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> >> -	}
> >> -
> >>   	/* Allocate Default Queue now and reassign during actual vdev creat=
e */
> >>   	vif->cab_queue =3D ATH12K_HW_DEFAULT_QUEUE;
> >>   	for (i =3D 0; i < ARRAY_SIZE(vif->hw_queue); i++)
> > [...]
> >=20
> > Thanks

Yeah, I wasn't clear enough, I meant adding the INIT_DELAY_WORK without mov=
ing
the rest of the code around.=20

Thanks