Received-SPF: pass (google.com: domain of linux-wireless+bounces-6238-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <0b31dda9-f38a-4ac6-8583-96a16ac9cfcd@quicinc.com>
Date: Fri, 12 Apr 2024 17:50:56 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: <quic_kangyang@quicinc.com>
To: Nicolas Escande <nico.escande@gmail.com>, <ath12k@lists.infradead.org>,
        <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: ath12k: add support to handle beacon miss for
 WCN7850
References: <20240412025149.1211-1-quic_kangyang@quicinc.com>
 <D0HYXSPMY8JE.17YSACO3ROKKZ@gmail.com>
 <6ee5664b-997b-45eb-89f9-5f75708c268a@quicinc.com>
 <D0I19V0104BZ.IN8THB2XCFLV@gmail.com>
In-Reply-To: <D0I19V0104BZ.IN8THB2XCFLV@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 4/12/24 5:23 PM, "Nicolas Escande" <nico.escande@gmail.com> wrote:
> On Fri Apr 12, 2024 at 10:47 AM CEST, Kang Yang wrote:
> >
> >
> > On 4/12/2024 3:33 PM, Nicolas Escande wrote:
> >> On Fri Apr 12, 2024 at 4:51 AM CEST, kangyang wrote:
> >> [...]
> >>> @@ -5986,6 +6055,20 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif)
> >>>    	lockdep_assert_held(&ar->conf_mutex);
> >>>    
> >>>    	arvif->ar = ar;
> >>> +	arvif->vif = vif;
> >>> +
> >>> +	INIT_LIST_HEAD(&arvif->list);
> >>> +	INIT_DELAYED_WORK(&arvif->connection_loss_work,
> >>> +			  ath12k_mac_vif_sta_connection_loss_work);
> >>> +
> >> Is there a need to move the following part ?
> >> Isn't just adding the delay work enough ?
> >
> >
> > Just checked, you are right, but should add delay work in add_interface().
> >
> > Will change in v3.
> >
> >
> >>> +	for (i = 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> >>> +		arvif->bitrate_mask.control[i].legacy = 0xffffffff;
> >>> +		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> >>> +		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> >>> +		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> >>> +		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> >>> +	}
> >>> +
> >>>    	vdev_id = __ffs64(ab->free_vdev_map);
> >>>    	arvif->vdev_id = vdev_id;
> >>>    	arvif->vdev_subtype = WMI_VDEV_SUBTYPE_NONE;
> >>> @@ -6316,16 +6399,6 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw,
> >>>    
> >>>    	arvif->vif = vif;
> >>>    
> >>> -	INIT_LIST_HEAD(&arvif->list);
> >>> -
> >>> -	for (i = 0; i < ARRAY_SIZE(arvif->bitrate_mask.control); i++) {
> >>> -		arvif->bitrate_mask.control[i].legacy = 0xffffffff;
> >>> -		memset(arvif->bitrate_mask.control[i].ht_mcs, 0xff,
> >>> -		       sizeof(arvif->bitrate_mask.control[i].ht_mcs));
> >>> -		memset(arvif->bitrate_mask.control[i].vht_mcs, 0xff,
> >>> -		       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
> >>> -	}
> >>> -
> >>>    	/* Allocate Default Queue now and reassign during actual vdev create */
> >>>    	vif->cab_queue = ATH12K_HW_DEFAULT_QUEUE;
> >>>    	for (i = 0; i < ARRAY_SIZE(vif->hw_queue); i++)
> >> [...]
> >>
> >> Thanks
> 
> Yeah, I wasn't clear enough, I meant adding the INIT_DELAY_WORK without moving
> the rest of the code around.
> 

I know what you mean --- Just add INIT_DELAY_WORK in ath12k_mac_vdev_create(). 

But i just checked with the person who just refactor the related code in patchset 'wifi: ath12k: Add single wiphy support'.
He also think add in ath12k_mac_op_add_interface() is better.


> Thanks
>