Received-SPF: pass (google.com: domain of linux-wireless+bounces-6272-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240412162510.29483-1-robimarko@gmail.com> <20240412162510.29483-2-robimarko@gmail.com>
 <4a1e0cb6-c319-4eb1-9bd1-5ff13eabfe1b@isd.uni-stuttgart.de>
In-Reply-To: <4a1e0cb6-c319-4eb1-9bd1-5ff13eabfe1b@isd.uni-stuttgart.de>
From: Robert Marko <robimarko@gmail.com>
Date: Fri, 12 Apr 2024 22:21:19 +0200
Message-ID: <CAOX2RU60K0JqeNWD5go4nM8aDnZmHQzF-Zx89MetqGxK4ySb2w@mail.gmail.com>
Subject: Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit
 property to limit channels
To: Christian Lamparter <christian.lamparter@isd.uni-stuttgart.de>
Cc: kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, 
	kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jjohnson@kernel.org, 
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org, 
	devicetree@vger.kernel.org, ath11k@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Fri, 12 Apr 2024 at 21:52, Christian Lamparter
<christian.lamparter@isd.uni-stuttgart.de> wrote:
>
> On 4/12/24 6:24 PM, Robert Marko wrote:
> > The common DT property can be used to limit the available channels
> > but ath11k has to manually call wiphy_read_of_freq_limits().
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> I've seen this before.
>
> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
>
> (dt-binding too. it has/had an ack)
> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
>
> sooo.... this is awkward.

Definitively,
I completely missed your patch set and we needed this in OpenWrt.

You were, first so your patch set should be applied.

Regards,
Robert


>
> > ---
> >   drivers/net/wireless/ath/ath11k/mac.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> > index c32be587000d..59bde128d351 100644
> > --- a/drivers/net/wireless/ath/ath11k/mac.c
> > +++ b/drivers/net/wireless/ath/ath11k/mac.c
> > @@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
> >       if (ret)
> >               goto err;
> >
> > +     wiphy_read_of_freq_limits(ar->hw->wiphy);
> >       ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
> >       ath11k_mac_setup_he_cap(ar, cap);
> >
>