Received-SPF: pass (google.com: domain of linux-wireless+bounces-6440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ebe80c29-4884-488d-ab83-c020f9c3bc81@intel.com>
Date: Wed, 17 Apr 2024 12:51:12 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v6 03/10] net: create a dummy net_device
 allocator
To: Jakub Kicinski <kuba@kernel.org>, Breno Leitao <leitao@debian.org>
CC: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
	<elder@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>, <nbd@nbd.name>,
	<sean.wang@mediatek.com>, <Mark-MC.Lee@mediatek.com>, <lorenzo@kernel.org>,
	<taras.chornyi@plvision.eu>, <ath11k@lists.infradead.org>,
	<ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	<geomatsi@gmail.com>, <kvalo@kernel.org>, <quic_jjohnson@quicinc.com>,
	<leon@kernel.org>, <dennis.dalessandro@cornelisnetworks.com>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	<bpf@vger.kernel.org>, <idosch@idosch.org>, Ido Schimmel <idosch@nvidia.com>,
	Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>, "Daniel
 Borkmann" <daniel@iogearbox.net>, Sebastian Andrzej Siewior
	<bigeasy@linutronix.de>
References: <20240411135952.1096696-1-leitao@debian.org>
 <20240411135952.1096696-4-leitao@debian.org>
 <20240412191626.2e9bfb4a@kernel.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240412191626.2e9bfb4a@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ditEbXNvOHNxbVJ6ellkY3E3UGVRNlN0T29JZ3BQaExBYjlMVFErTnRrSHRi?=
 =?utf-8?B?SHM0Y3JBR2dwODNyeCtYZnBHcVVtN0J6STlYWUhuV2VVRVVPNkhoYmMzamx3?=
 =?utf-8?B?eENDSHUzQTF1cUtTbFNFNlMwQ0VyZXhXaG1YTG1oTFpReTJUcjIrdXo4L1JQ?=
 =?utf-8?B?L2c0bXlmdDJnd2dQQjFsNzMyUDVLTjVjd3E5d3ByTHF2aTRNSHI0NnlBMHRE?=
 =?utf-8?B?TEF6cHZLZjlHTmJKTHY5V3o4T1Foc0FMTFBuQ3JrbzZNR2hIUmJYa0Nqc1I5?=
 =?utf-8?B?VndTblBWUEM1T0RibElqdnJKSU1LRHRUSmxqWVVoQ0FBMHpNOFBTSzh2SVB4?=
 =?utf-8?B?V3QzanB3SDdud2R5bll1eFRlaEhTMkZKYlNTMlp3V3VIUVhKMkN0OGFHTmpL?=
 =?utf-8?B?ci90dGhxRjgwUUg4UHRtR0xKMzFteDV4c1IwTFJIc0s5dGFORGh2OHpUd1Vs?=
 =?utf-8?B?WldaKzZjdGUvME5jby9KZStMN0ZMdVBTS3lJWU1WNjd5US9uUk9GZlVOeGta?=
 =?utf-8?B?VGtTaFpWdlN5SlIrSXFKV0dKbkRyc3ducE9oYXhzYkhFa0ZSdHdwMUxOK2xp?=
 =?utf-8?B?YzBLaG03MkZlb0xQSHRlMnl3YWNwWE9RZGt4aURiSk1URkVIQUhnd2QrK0hB?=
 =?utf-8?B?OG9kYWlMWExYMzM1bVFZVitIeE1mK1VZeHZNdWRZNEZPSENBYXlpZVRpTE5P?=
 =?utf-8?B?VGNHSkl6cEhrcW1aaTR2YkdwVVhFdDBDQ05Fd3Z3blhpd2d2VVNjZzUxNHNz?=
 =?utf-8?B?dmdWSFNGWDR0dWc2cWpWQ2k4Rm1VVEM1SXpld25kM0l4c0w5bkFyOGdOWGgz?=
 =?utf-8?B?ajN5d2tNWjAzbnVrUVVHRHA1dTRoZmUzdE1ENmlvVXQ4bkFqNDc4YUYwMGRE?=
 =?utf-8?B?SW9EMnhJbnVvZ0JuTHlSZzNWTm1TMUZ2eDYzQUdvMDZramhtNXNOa2YrTWVp?=
 =?utf-8?B?bTNOcGxZWjB0REI5TStoczcvNzIvNWJIVXJqMkNTOTZlM3VwSTNmWWlKckEz?=
 =?utf-8?B?cjQzUkJRSU9XK0tnZzFwUDlhM3g1bENxMzV1ZWNGT3JXVWU3T0hDSlpUQlda?=
 =?utf-8?B?SkJsUndRdVZmSktPdlkxM2x3cGVGbE52ZVRReFdNS0lKTFJtRy9aQjg1SHpp?=
 =?utf-8?B?YTZOb29YUU5GUnRnODlqTUJwNHdFbkcxWGszdFYyRi9LMzBFWUo4Qnl2TUp4?=
 =?utf-8?B?cGx2YTUrbmlqVUdaQkYvNXVpekFVaE5sMWs5ZzBrWTlJenVqeGVxSUplOWtD?=
 =?utf-8?B?K2dMR1h5L0xCWWltWUFtanVYQXJMcEQyeFVtaFRlMGpiQ3BlOGtjU3lLcm41?=
 =?utf-8?B?ZHdHQ2sxd21FNFgzeXpLc0JBU3NSclBZMjhBL1FWYWtoZlVWdXVKY3AvN3Js?=
 =?utf-8?B?QUViUkpRQWwrY1JVQjZOMCtoQnFZelhMM1BFS0dlODZYcGJUcVh3Z3QrUWRi?=
 =?utf-8?B?ZTVjc0NINmtIUWQzbk41RkFKdWNDS0dvSjlTVlZVcUIzQjkwWHNHK3lqMi9F?=
 =?utf-8?B?RUE3NU00K05XRmNlSklNY0UyZXBCbjZ5UTkyeGxseEN3U2Qxa1NTYjBIQzZR?=
 =?utf-8?B?djF6eUw1MkRBdW4wL3Z1RGRkMUk0V0dLMk93ZHZOWTNwNUwrcUtLMHZ1NzdP?=
 =?utf-8?B?bG1EN1IwUWZkVlFhYjBvZ2tEaGZkNE11LzNjMEVYRVdEa2ZSc09KeTZjWmVo?=
 =?utf-8?B?RDM0RGdlTXZYQWNzemhGOTY5OHUrOFhPemFBbWZGL09OaDl2NUlvSGVRL1pQ?=
 =?utf-8?B?T0NIU1M0NUVTczJnWWhMdEFuemhGZUFzTmtRSERvd28zV1pIMFJPQlYwUGcv?=
 =?utf-8?B?MjU5R1p5b3BXUUlWaWMwS0h2dmcvK01SS0lLU0c0TXR1Nkd3TmN4Rm5ld0xI?=
 =?utf-8?B?bEN2Z3hCVkluenhjTHBjaHlmN0U2b1MyaGpmNnlKY01RWUkwVHVFejZQVVZn?=
 =?utf-8?B?SU5vRzJScnVENnZrdm5ZR2tISFFLdlEycVZoeXl5QmlTR1FLcFhLZ3hoeGpt?=
 =?utf-8?B?N1pVajd0QXAzb1orL3RKUXNZbkFBNmtCWkI1VUt0d2gza3FpMzl6eWdsbGtX?=
 =?utf-8?B?REM4T2k1Z1QrOHc3N3pWM2pPdXUxektyZms3cmExVzhaeXNsYVNKeUVwajJm?=
 =?utf-8?B?NTQvRzl6dTA4VGRBSnRMMWtOWDAwUGlrVUF3UUwwdmRxM1A0dlgxN1VFL0x6?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8801ad41-d2e4-43f9-afbc-08dc5ecc511f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 10:51:20.9259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Espmzm32iVn2wmUVDEHZMgtFOxyusDNyneO/o7USCOAWF5qsOftquwlxz4JALuQaIXZxtLRyDLVey0IDqQQG0j00tiL4l1rnBZEVA0EVS7A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8597
X-OriginatorOrg: intel.com

From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 12 Apr 2024 19:16:26 -0700

> On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote:
>> +/**
>> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
>> + * @sizeof_priv: size of private data to allocate space for
>> + */
>> +struct net_device *alloc_netdev_dummy(int sizeof_priv)
> 
> Sorry, one more round :)
> 
> We started using -Wall for kdoc (./scripts/kernel-doc -Wall $files)
> recently and it now complains about missing return values...

Just FYI: kdoc accepts only this pattern:

 * @last_param: blah
 *
 * Return: blah

NOT

 * Returns: blah

neither

 * Returns blah

Only "Return: blah" with a blank newline between it and the last
argument (or extended description).

Thanks,
Olek