Received-SPF: pass (google.com: domain of linux-wireless+bounces-6456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <9f0163ae-75bc-4a65-bc92-c9ae181ad83c@gmail.com>
Date: Wed, 17 Apr 2024 09:14:41 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: putting future iwlwifi firmware into intel/ ?
Content-Language: en-US
To: Johannes Berg <johannes@sipsolutions.net>, linux-firmware@kernel.org
Cc: linux-wireless@vger.kernel.org, miriam.rachel.korenblit@intel.com
References: <fec30176f437d565d4c1dfc4944373f117d75a64.camel@sipsolutions.net>
 <9aa64d50-cb4d-4118-bc27-86c23410ff8b@gmail.com>
 <f65765b29ea7503fbbaa5e047c95a82de6fc2083.camel@sipsolutions.net>
 <b0e70576-a53f-4d03-a503-ddf1f98bbe9d@gmail.com>
 <b712f48a3e35221b7ff7f4c8cb495b5159bdd367.camel@sipsolutions.net>
 <b7876373-08d9-4948-a49a-e79f42f3abcb@gmail.com>
 <2278e0d1026ed336559adbc9ffbf6e945eba422e.camel@sipsolutions.net>
From: Mario Limonciello <superm1@gmail.com>
In-Reply-To: <2278e0d1026ed336559adbc9ffbf6e945eba422e.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 4/17/24 09:09, Johannes Berg wrote:
> On Wed, 2024-04-17 at 08:58 -0500, Mario Limonciello wrote:
>>>
>>> Yeah, I guess. Though not actually sure, do we need to support new
>>> kernel + old firmware install?
>>
>> I'd say you should.  Here's a few examples of why:
> 
> Right, agree.
> 
>> So yes; do the symlinks when you move directories.  It's one line in
>> WHENCE per file that you want a symlink.
>>
> 
> That doesn't achieve it though. It means the driver needs to try for the
> file in intel/ and then fall back without the intel/ if it's not found.
> 
> Or just look for new files in intel/ and old files without intel/, but
> then you don't really need the file move/symlinks?
> 
> johannes

It's probably easiest to look in intel/ and then fallback to the 
toplevel path if -ENOENT and try again.

Like Kalle mentioned, wait a few years and then tear out the fallback 
code and the symlink creation.