Received-SPF: pass (google.com: domain of linux-wireless+bounces-6472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Lewis Robbins <lewis.robbins2@gmail.com>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw88: suppress messages of failed to flush queue
Thread-Topic: [PATCH] wifi: rtw88: suppress messages of failed to flush queue
Thread-Index: AQHakGhMPXSMmu1HQU6i74qytbmsgrFsgmkAgACrxzA=
Date: Thu, 18 Apr 2024 00:31:27 +0000
Message-ID: <fc6072f3deda43eeb138356f973631b6@realtek.com>
References: <20240417014036.11234-1-pkshih@realtek.com>
 <20240417221451.43964-2-lewis.robbins2@gmail.com>
In-Reply-To: <20240417221451.43964-2-lewis.robbins2@gmail.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Lewis Robbins <lewis.robbins2@gmail.com> wrote:

> Thanks, I tested it for 30 minutes and didn't receive any superfluous war=
ning message. Only thing I could
> find was the comment above not reflecting the (new) debug print (but very=
 nit-picky from me).
>=20
> Acked-by: Lewis Robbins <lewis.robbins2@gmail.com>

Acked-by is used by maintainers, so I used your Tested-by by v2. [1]

>=20
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wirel=
ess/realtek/rtw88/mac.c
> index 9038e2311596..3d1a886262d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -1026,7 +1026,7 @@ static void __rtw_mac_flush_prio_queue(struct rtw_d=
ev *rtwdev,
>                 msleep(20);
>         }
>=20
> -       /* priority queue is still not empty, throw a warning,
> +       /* priority queue is still not empty, throw a debug message

Thanks for pointing this.=20

>          *
>          * Note that if we want to flush the tx queue when having a lot o=
f
>          * traffic (ex, 100Mbps up), some of the packets could be dropped=
.

[1] https://lore.kernel.org/linux-wireless/20240418002916.5965-1-pkshih@rea=
ltek.com/T/#u