Received-SPF: pass (google.com: domain of linux-wireless+bounces-6475-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: rtw89: pci: correct TX resource checking for PCI DMA channel of firmware command
In-Reply-To: <20240410011316.9906-1-pkshih@realtek.com>
References: <20240410011316.9906-1-pkshih@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Message-ID: <e40848a0-7b9c-4faf-9cd6-7c003c0fbf81@RTEXMBS04.realtek.com.tw>
Date: Thu, 18 Apr 2024 09:06:01 +0800

Ping-Ke Shih <pkshih@realtek.com> wrote:

> The DMA channel of firmware command doesn't use TX WD (WiFi descriptor), so
> don't need to consider number of TX WD as factor of TX resource. Otherwise,
> during pause state (a transient state to switch to/from low power mode)
> firmware commands could be dropped and driver throws warnings suddenly:
> 
>    rtw89_8852ce 0000:04:00.0: no tx fwcmd resource
>    rtw89_8852ce 0000:04:00.0: failed to send h2c
> 
> The case we met is that driver sends RSSI strength of firmware command at
> RX path that could be running concurrently with switching low power mode.
> The missing of this firmware command doesn't affect user experiences,
> because the RSSI strength will be updated again after a while.
> 
> The DMA descriptors of normal packets has three layers like:
> 

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

c6330b129786 wifi: rtw89: pci: correct TX resource checking for PCI DMA channel of firmware command

---
https://github.com/pkshih/rtw.git