Received-SPF: pass (google.com: domain of linux-wireless+bounces-6489-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: David Lin <yu-hao.lin@nxp.com>
To: David Lin <yu-hao.lin@nxp.com>, Brian Norris <briannorris@chromium.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>, "francesco@dolcini.it"
	<francesco@dolcini.it>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>, Francesco
 Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP mode
Thread-Topic: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP
 mode
Thread-Index: AQHab2oqV1El38Ap00yuI3DpHpR6T7E5l5eAgAM6irCAMNJAYA==
Date: Thu, 18 Apr 2024 03:37:35 +0000
Message-ID:
 <PA4PR04MB9638A61A144364C3567AEA76D10E2@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240306020053.18054-1-yu-hao.lin@nxp.com>
 <20240306020053.18054-3-yu-hao.lin@nxp.com> <ZfTrm7bxMykHO-M-@google.com>
 <PA4PR04MB9638D5722670E38B5691B948D12D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
In-Reply-To:
 <PA4PR04MB9638D5722670E38B5691B948D12D2@PA4PR04MB9638.eurprd04.prod.outlook.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?tLSyVGe11HqmV6ikSH5uDORkqpctTP7PKk9r3jmsJq1BysdFFElLq8eWd0Vm?=
 =?us-ascii?Q?og0scfxA6aQzSY90e9k+pgZj0MSdOV1hxp1qohRYPvIbmNRZ+h+wbvDP2vrK?=
 =?us-ascii?Q?pyJ8o1yiHQzFpfo3ved0kcXzc9X/xzQZJzQBak5yilEjtt+5tBzRxPooDogn?=
 =?us-ascii?Q?43WqikY1ZtjK0z4SVTpKJo0VN1Rt4gAQpclOt6RXH3aVpIbOb4f0Jvdk7wbu?=
 =?us-ascii?Q?DA+BV10e2ZN574nGAJkR3yklcJMiIC8soMQ6yLn0xvG3PFWBF/rmxQA4TVoV?=
 =?us-ascii?Q?TkXEm5tEEVdEPYTSL13fmriuVbLypGYINAqqeHFRvLVtv95jNRNqCWT5D/1e?=
 =?us-ascii?Q?JireKQHbNzuBwIotxRvmcb5QVY20XizubpSLotibFfX5ka1uGDdEwjworgpH?=
 =?us-ascii?Q?0MCiet7mzXYApT6XKe4+zH6ra216Ov+/UTwoCgYFXZ4DeKLVozB/yh7NEHd9?=
 =?us-ascii?Q?7lFjcULwPlkg1OgSDIaEwoG3TmSHDYRH7asqqwqZUiFk8i0fUsR2sF4c+MyN?=
 =?us-ascii?Q?k4GLxJiewALZw8mmiQkid4wod5HewK6dOJnCDY0kCHVmMMXuDNmjXNWW8Zsu?=
 =?us-ascii?Q?a8LQAVSBjaAwFvztmMpEIPA/k7f51AoZvx28H58EN+0wA3yveF8813YcnDB5?=
 =?us-ascii?Q?ogakD6W3pVpGQ3Dqf5nG+0mvEUKDoUKEKGZPkIqmE6N1UrwQF1vI9OB3Dwhv?=
 =?us-ascii?Q?9Lesovk4SQ6JlLgYYfZdR4KlLlyDdiruO7fSNtodMwGl1ONGidC2c4wnPEQO?=
 =?us-ascii?Q?6J5O6XF1RIrrLtQLJO9Q7xlYrLis5CRW3uvnPV9dJWIv7C70v1asSiW2yru4?=
 =?us-ascii?Q?Ep+ags8qZE4ndhTStCdtU4j6gF7A03mriR4q4pfMS6oWDqYpUZh/cKYFUP7Q?=
 =?us-ascii?Q?m7KyG+r45g+bqKquE0hJaWts8c0lazplnL73sNJQAjHR1DQc8zXY3JYo33d9?=
 =?us-ascii?Q?M92uCB7uY7ZaZyUJ4kA0BezQ7vPUVfG+/+DshkyQoz4mIN07oEWqHxOGN3K/?=
 =?us-ascii?Q?V/3BpMRMT3ihbDX9q68lQ4X+TFBVhAMBfvYSMciCArm0FsksuABdmex+KIvR?=
 =?us-ascii?Q?UL5LINykkcp7NI7CUKYxl4BUnMNRTt+4BKHmxYDLm3kn5KnJeyXrszIcdSqn?=
 =?us-ascii?Q?0TH3X/w064MfQnPnhJTDzb3SBt/xK0Pv/ZpFyo/CccwzKgyO7Qk627JNW5c0?=
 =?us-ascii?Q?7XI5+aXSLgzePqwB+Q1YA543DfkxxbGYJjIRCgJlQCTMB9EV9k3V8C3rTaaS?=
 =?us-ascii?Q?lbOQCgfI/ukCr813AoXQmIcB0t2Dl0uLn1MpiVyd/U21BYmxneD6QcPI+iyB?=
 =?us-ascii?Q?GWCuSAltamXJWnBZ0N1r5+6KQUmgM2b6LDYrcbImgOh+wj+pmNCfr/1rVPUv?=
 =?us-ascii?Q?rBpxQeoi1sbxS6xg1wMxGcCl2Fqgwy7t9Vs9bXNek4NnZA1K+PXQ/9P1oCj8?=
 =?us-ascii?Q?X8CDWuih2UP4OhHmdFzDLCYoAUQr/yDeH9aT2kg28FFfB13rjoM9JzPHRQYb?=
 =?us-ascii?Q?MG2pH+BIMqm5N0xdNk/esFCz8k0aOFk41cBMpG0ro+et4fCQTRNpMDy79kT5?=
 =?us-ascii?Q?X+M82R6mQ4oJK3X53euFWn08dJ7spz89ZKrod0uV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0c22837-6c9f-4038-f11d-08dc5f58e315
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 03:37:35.0979
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: do9jzOMCeIsb6ti/z8B3X0xV2AXzwUPq/0tRxVp+4jDW7i60oFU9xk9NLEVTSDNMK75+vwIoT42VTL4MusIJLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9518

> From: David Lin <yu-hao.lin@nxp.com>
> Sent: Monday, March 18, 2024 10:04 AM
> To: Brian Norris <briannorris@chromium.org>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: RE: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP
> mode
> >=20
> > From: Brian Norris <briannorris@chromium.org>
> > Sent: Saturday, March 16, 2024 8:45 AM
> > To: David Lin <yu-hao.lin@nxp.com>
> > Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> > kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> > <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> > <francesco.dolcini@toradex.com>
> > Subject: [EXT] Re: [PATCH v9 2/2] wifi: mwifiex: add host mlme for AP
> > mode
> >
> > Caution: This is an external email. Please take care when clicking
> > links or opening attachments. When in doubt, report the message using
> > the 'Report this email' button
> >
> >
> > On Wed, Mar 06, 2024 at 10:00:53AM +0800, David Lin wrote:
> > > Add host based MLME to enable WPA3 functionalities in AP mode.
> > > This feature required a firmware with the corresponding V2 Key API
> > > support. The feature (WPA3) is currently enabled and verified only
> > > on IW416. Also, verified no regression with change when host MLME is
> > > disabled.
> > >
> > > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> >
> > Quick pass for now; nothing jumps out at me today, but I'll give a
> > better look/Ack next week:
> >
> > > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> >
> >
> > > @@ -3951,12 +3974,43 @@
> > mwifiex_cfg80211_tdls_cancel_chan_switch(struct wiphy *wiphy,
> > >       }
> > >  }
> > >
> > > +static int
> > > +mwifiex_cfg80211_uap_add_station(struct mwifiex_private *priv,
> > > +const u8
> > *mac,
> > > +                              struct station_parameters *params) {
> > > +     struct mwifiex_sta_info add_sta;
> > > +     int ret;
> > > +
> > > +     memcpy(add_sta.peer_mac, mac, ETH_ALEN);
> > > +     add_sta.params =3D params;
> > > +
> > > +     ret =3D mwifiex_send_cmd(priv, HostCmd_CMD_ADD_NEW_STATION,
> > > +                            HostCmd_ACT_ADD_STA, 0, (void
> > *)&add_sta,
> > > + true);
> > > +
> > > +     if (!ret) {
> > > +             struct station_info *sinfo;
> > > +
> > > +             sinfo =3D kzalloc(sizeof(*sinfo), GFP_KERNEL);
> >
> > Couldn't this just be stack allocation?
> >
> >                 struct staion_info sinfo;
> >
> >                 cfg80211_new_sta(priv->netdev, mac, &sinfo,
> > GFP_KERNEL);
> >
> > I'm not sure you need to kzalloc() something here, if you're freeing
> > it a few lines later.
> >
>=20
> Will modify it in patch v10.
>=20

This modification will let stack overflow. Patch v10 will keep original cod=
e.

> >
> > > +             if (!sinfo)
> > > +                     return -ENOMEM;
> > > +
> > > +             cfg80211_new_sta(priv->netdev, mac, sinfo,
> GFP_KERNEL);
> > > +             kfree(sinfo);
> > > +     }
> > > +
> > > +     return ret;
> > > +}
> >
> > Brian