Received-SPF: pass (google.com: domain of linux-wireless+bounces-6496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <137a9ecb-d5de-4471-bbc1-32986b735f28@linutronix.de>
Date: Thu, 18 Apr 2024 08:47:31 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] wifi: rtl8xxxu: enable MFP support
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>,
 Bitterblue Smith <rtl8821cerfe2@gmail.com>,
 Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
 "stable@vger.kernel.org" <stable@vger.kernel.org>
References: <20240417093352.1840632-1-martin.kaistra@linutronix.de>
 <20240417093352.1840632-3-martin.kaistra@linutronix.de>
 <6a1571aadad1486eb83a19437e1d2437@realtek.com>
Content-Language: de-DE
From: Martin Kaistra <martin.kaistra@linutronix.de>
In-Reply-To: <6a1571aadad1486eb83a19437e1d2437@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Am 18.04.24 um 02:19 schrieb Ping-Ke Shih:
> Martin Kaistra <martin.kaistra@linutronix.de> wrote:
> 
>>
>> In order to connect to networks which require 802.11w, add the
>> MFP_CAPABLE flag and let mac80211 do the actual crypto in software.
>>
>> When a robust management frame is received, rx_dec->swdec is not set,
>> even though the HW did not decrypt it. Extend the check and don't set
>> RX_FLAG_DECRYPTED for these frames in order to use SW decryption.
>>
>> Use the security flag in the RX descriptor for this purpose, like it is
>> done in the rtw88 driver.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
> 
> I would like to change subject to
> "wifi: rtl8xxxu: enable MFP support with security flag of RX descriptor",
> because the same subject as former patch cause confusing. I can change that
> during committing.
> 
> Others are good to me.
> 

ok, subject change is fine for me.
I just noticed though, that I named the enum "rtw_rx_desc_enc" instead of the 
probably more appropriate "rtl8xxxu_rx_desc_enc". Should I change that?

Martin