Received-SPF: pass (google.com: domain of linux-wireless+bounces-6504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: David Lin <yu-hao.lin@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>, "kvalo@kernel.org"
	<kvalo@kernel.org>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>, Francesco Dolcini
	<francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client
 mode
Thread-Topic: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for
 client mode
Thread-Index: AQHakVadTJiKH7Fbwkii2Ljo0AqkAbFtkzUAgAAc2KA=
Date: Thu, 18 Apr 2024 08:24:35 +0000
Message-ID:
 <PA4PR04MB963811B14B2FE5ED8A56AE39D10E2@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240418060626.431202-1-yu-hao.lin@nxp.com>
 <20240418060626.431202-2-yu-hao.lin@nxp.com>
 <ZiC_wjm79RvrC1jp@gaggiata.pivistrello.it>
In-Reply-To: <ZiC_wjm79RvrC1jp@gaggiata.pivistrello.it>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Ao1FukzvouRnvDTvN6j6fPY2f42eYmdOjO42LedPo8YovtxbT2FryWddoddX?=
 =?us-ascii?Q?aS8yKOAsDvZAHONkTRGqoZciEgoKsJ549O9B4CzjcP6eEzNARm+wupQxzQsx?=
 =?us-ascii?Q?rEfemoT4TPY7OWtnywIqwsznF7sUqya66y9unlWfNgGpqYsJbFUqne97aAgS?=
 =?us-ascii?Q?r4zNW+P033ISrFeqbeE0u2yM8VymyGdBxUp03EM7sc3epYC1xHc/pRW8YmxH?=
 =?us-ascii?Q?rVclNlSH8wJlas5+7RKsUxQd1Ja38RU1nuwUrx/FPuv6Ry86U1VKrkPQZJcq?=
 =?us-ascii?Q?wU6q14+F8FMHUz1GBpzJQHI+LFRwjesPOBTgyylOjbf03Kza1sTRxlaLUEMb?=
 =?us-ascii?Q?95YB9iAa7xzF1V6utHncC/VTj4kMpkdyTJ5FLVP7bWMOeQHB2PXoNPJY0UnO?=
 =?us-ascii?Q?GjbdGTpHC9lNFX38+TaJ81R2UoKwVsQEqFUl1wL1sg4BdFdefAXS3TWFav6J?=
 =?us-ascii?Q?ZUWnwBo6DmaYFLIg/XHh8HrSRZAZnPdo1PQpLrCpx2eqPPuFoRGri2Ch+2mk?=
 =?us-ascii?Q?GAQhFLTbATQ77vI2LeLI6PuC3QfBpwPCzM154eiAleVpPS6VwVey17EHGkeE?=
 =?us-ascii?Q?5MO4hChw2ybVvBTsZYIaERusxxhVJQOJCQB1X0RiSTAq+1/uhIj9C8TBOvYb?=
 =?us-ascii?Q?IcFw5SjghFGzGHG9dMYUJGprx5r03n6SUemT5pBYQSLHRSEDq6l9UDflMYPN?=
 =?us-ascii?Q?DXI7zlr1+QNTpkw7lvr5ckmVNrl5Q9LVDBxwbjyde+JqLFuMgTIeGpAZImIi?=
 =?us-ascii?Q?ws3gMuZg1a8WPMP8mtcGoxcgyNwILW7HQudTKUiFyk2ElMMGsscDCBMjS0oe?=
 =?us-ascii?Q?QoTOh8Xvg8iBv0lJv5zu1iqbXgg3S0IK+Ua+Fr2U0IT0xbeuP7YAhH0Eu9Pn?=
 =?us-ascii?Q?g0AmvLIZQB2C8nTUqGP2A01ym/b9brwXgkRxS609XuEi+wf/jewmfti6MK7k?=
 =?us-ascii?Q?Yzr/tL2K6cAATF645BgSZdBri+cJacO30KEGdISdmoSwfhtaSOq/WdeDJt16?=
 =?us-ascii?Q?B6++bCNcfsNdyT0hAivQPPtqtEykzvMUot6dMhBPGud3NbvwNoHLfYtkLHnz?=
 =?us-ascii?Q?d4eIFDb4xRFKeX/f5vmMrdNsctLQPYVmGiPmDOK8xMbRc3ZhJpvb/BqPE2wt?=
 =?us-ascii?Q?XIr4FRkdPt0SAgSeHyQdmdeOsWWbauKLGjvg6kWbCP1seVKPQIeVyvQg48t4?=
 =?us-ascii?Q?J62YMfni//2B5R2EmmFX2x4yytJ/8VtLIXVRgyK+Z0K1CLOqtk4u3XYK+Yic?=
 =?us-ascii?Q?VaNWEV+VfPP6xFQ2Z5HixgczrDwOrl499hufjgvgMId4jYStjW2LbP1ePosO?=
 =?us-ascii?Q?SQPg35G+AXc0BdtY5JtjkSQK8KgRAyggezG7b09j2LhwcSZAAX9Pr3RHh+lK?=
 =?us-ascii?Q?SVv5d8XvD0k4ElX3nAQUplctEMrv9Rp6ttmwoBaHKoa/HVbsOB9U12aTn7kQ?=
 =?us-ascii?Q?SWqo2RJdVd9+cZ+nVBp+AU+htazkPUClFZwRoBZaqFBq4CfFu49HDQW9omhD?=
 =?us-ascii?Q?aLLrLb0+c/9XSCOlSg79nxdWlXToqI9wE789WlxOMuWmhceIbGWydjF/D38u?=
 =?us-ascii?Q?ZRP1T10UUdgFjZwMaQCXavdPhoqt1c9zuxFAnh8+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b8c28f2-8071-4fa0-a1fd-08dc5f80fb8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2024 08:24:35.9901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6yYTIN9nhgMu/tWcByFTE0MilCCajnM4/vu4Jn8/ROqNHLZuLIk8M6A3GpzOG0uVJ03ejseb744SKrjHNnX/kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8874

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Thursday, April 18, 2024 2:38 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Pete
> Hsieh <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for clien=
t
> mode
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Thu, Apr 18, 2024 at 02:06:25PM +0800, David Lin wrote:
> > Add host based MLME to enable WPA3 functionalities in client mode.
> > This feature required a firmware with the corresponding V2 Key API
> > support. The feature (WPA3) is currently enabled and verified only on
> > IW416. Also, verified no regression with change when host MLME is
> > disabled.
> >
> > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>=20
> ...
>=20
> > diff --git a/drivers/net/wireless/marvell/mwifiex/util.c
> > b/drivers/net/wireless/marvell/mwifiex/util.c
> > index 745b1d925b21..3817c08a1507 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/util.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/util.c
> > @@ -417,6 +456,47 @@ mwifiex_process_mgmt_packet(struct
> > mwifiex_private *priv,
>=20
> ...
>=20
> > +                             mwifiex_dbg
> > +                             (priv->adapter, MSG,
> > +                              "assoc: receive disassoc from %pM\n",
> > +                              ieee_hdr->addr3);
>=20
> The way you indented this does not seems kernel coding style compliant ..=
.
> however checkpatch does not complain ... so maybe I am just wrong.
>=20
> In case you need to send a new version, please keep the open parenthesis
> together with the function name
>=20
>                                 mwifiex_dbg(priv->adapter, MSG,
>                                             "assoc: receive disassoc
> from %pM\n",
>                                             ieee_hdr->addr3);
>=20
> (yes, it's 81 column - and it's fine).
>=20
> Again, IMHO, do not send a v11 just for this trivial change.
>=20
> Francesco
>

Because checkpatch.pl doesn't complain about this kind of coding, I use thi=
s way to let code less and equal 80.
I will correct it if new version of code is needed.

David
=20