Received-SPF: pass (google.com: domain of linux-wireless+bounces-6523-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <cc3c4c40-e07b-42c4-8d24-80d67fa1f46f@gmail.com>
Date: Thu, 18 Apr 2024 15:22:10 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 5/6] wifi: rtlwifi: Clean up rtl8192d-common a bit
To: Ping-Ke Shih <pkshih@realtek.com>,
 "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
 Stefan Lippers-Hollmann <s.l-h@gmx.de>,
 Christian Hewitt <chewitt@libreelec.tv>
References: <561cc9e4-3ddc-40cd-a076-2c14c44eea87@gmail.com>
 <4e47c56c-4b7f-4ae6-84b9-05f0cac97dac@gmail.com>
 <72bd1a7172154d4e9a79678e5151cdf3@realtek.com>
 <ad6057a1-9d3b-4b2c-ac47-5df688f5bed5@gmail.com>
 <42113d0a089d4096aa1b5cc3861ac297@realtek.com>
Content-Language: en-US
From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
In-Reply-To: <42113d0a089d4096aa1b5cc3861ac297@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 18/04/2024 03:49, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>>
>> On 17/04/2024 09:48, Ping-Ke Shih wrote:
>>> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>>>
>>>> @@ -228,35 +238,25 @@ static void _rtl92d_fill_h2c_command(struct ieee80211_hw *hw,
>>>>                         break;
>>>>                 }
>>>>         }
>>>> +
>>>>         while (!bwrite_success) {
>>>>                 wait_writeh2c_limmit--;
>>>>                 if (wait_writeh2c_limmit == 0) {
>>>>                         pr_err("Write H2C fail because no trigger for FW INT!\n");
>>>>                         break;
>>>>                 }
>>>> +
>>>>                 boxnum = rtlhal->last_hmeboxnum;
>>>>                 switch (boxnum) {
>>>> -               case 0:
>>>> -                       box_reg = REG_HMEBOX_0;
>>>> -                       box_extreg = REG_HMEBOX_EXT_0;
>>>> -                       break;
>>>> -               case 1:
>>>> -                       box_reg = REG_HMEBOX_1;
>>>> -                       box_extreg = REG_HMEBOX_EXT_1;
>>>> -                       break;
>>>> -               case 2:
>>>> -                       box_reg = REG_HMEBOX_2;
>>>> -                       box_extreg = REG_HMEBOX_EXT_2;
>>>> -                       break;
>>>> -               case 3:
>>>> -                       box_reg = REG_HMEBOX_3;
>>>> -                       box_extreg = REG_HMEBOX_EXT_3;
>>>> +               case 0 ... 3:
>>>> +                       box_reg = REG_HMEBOX_0 + boxnum * 4;
>>>> +                       box_extreg = REG_HMEBOX_EXT_0 + boxnum * 2;
>>>
>>> Should be "* 4" as well?
>>>
>>> box_extreg = REG_HMEBOX_EXT_0 + boxnum * 4;
>>>
>>
>> No, because they are only two bytes apart in this old chip:
>>
>> #define REG_HMEBOX_EXT_0                0x0088
>> #define REG_HMEBOX_EXT_1                0x008A
>> #define REG_HMEBOX_EXT_2                0x008C
>> #define REG_HMEBOX_EXT_3                0x008E
>>
> 
> Sorry, I misread them in rtl8188ee/reg.h. 
> 
> To clearly know what 4 and 2 are, how about to define:
> 
> #define SIZE_OF_REG_HMEBOX 4
> #define SIZE_OF_REG_HMEBOX_EXT 2
> 

Sounds good.