Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp355211lqt; Thu, 18 Apr 2024 18:44:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX+LIMsRodaVG/YDC23V3WANw0XLjZRUjiOpETC/mBSWVDOfvEqNJH6Zws1L7pCU/8Pscv4HO9GVHW9Ox6FkIx+x2VcYxSpxCm2n4lUEg== X-Google-Smtp-Source: AGHT+IE8StffchU5821wMXe8Ip4SjBq5XpPCHUwAJ+4KDJHz8HufXdjtDXMZ1QGqVxDHul5K6RM9 X-Received: by 2002:a17:902:c3d5:b0:1e8:5079:b46d with SMTP id j21-20020a170902c3d500b001e85079b46dmr829926plj.34.1713491045763; Thu, 18 Apr 2024 18:44:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713491045; cv=pass; d=google.com; s=arc-20160816; b=yDNFFGzEG7WgOwFJKsb6qcFkdQb1XC0c/RtxcJChHQp/rrraQM1sxJDUdxgaDJDmGN bobf20RoEV/U1PyOcy7DMP4DGrKdS6WEa2rQ3Ss8EZuNJOanIpY650crIhJehQKkwXYy CwrmYW8MHUhr/+oIBqg4EjoPhZXEiC4RW6JSrdM0IutPCWLrPRJE5JP1xOH+XbZ/nkov Ixqg0B/JWe1SGCZeo9BKT4nTT08irAeK9wFwUpe4//uVvjxmQzyXvGxv4AvCtzGf61CW pMOQrfAa6A+Pyd0OsIuzcmmfKM/QRzK4rFiBx076LLBzQ2A133GPbWSUI7vRwTGX2Vcp 4YgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:cc:to:from; bh=im0pErIgZTXY2o0eEoXAw4y93iTq2UlhgMAX1Qp9Cq8=; fh=lCeYhTsHebQVymYhE9ECKg2yk4kOqXBDfwpd9qqym+w=; b=eQhdHr91Woao8Sh0vYWA0aievQHsVV94V6CsJtsZzMkyt5FpdYfvXjcDeamBAEc4WY M5zKzr+Nt2lGuVefOK0YI7VTD2josT4Csw4ghcLx+QSd/yeIcjhcLyCO0HbX21EJS1X/ pqQ4U/mZCXk+pdOMYBtifSDxTjSvyFhOqyhddqpWA51U9hqA5C69srwszb0DlWwDCidq Tl6ug1G5oWjHX5QFZWd/CLhNqXitBn3pbSyAaXHcLpfxZ3mQmCbgZ5FmopnjWPz77Y8D 7diGo1AGX8mTBu/iLd4krCMqPbcW7g9Zo9ZIjF7aTFqY1mYwSlTqJPvakDbXqQvmSKbh eZgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-6545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6545-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s7-20020a17090302c700b001e3e41b9f2csi2488306plk.15.2024.04.18.18.44.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 18:44:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-6545-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6545-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0F8342840D3 for ; Fri, 19 Apr 2024 01:44:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2A2C910FF; Fri, 19 Apr 2024 01:44:03 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBFC10F9 for ; Fri, 19 Apr 2024 01:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713491043; cv=none; b=KlqZklJemQoVsPUh929gZB7Mplsq4B91zGcsQSV6QgpJ+gvFumdb5S6LhUK/3AFQum6424WUi0G74fgGZ3eOOQW27OLtJ6wL2W4nPgANdI0kULG35UVDPHMet2CY/5MWOxkLJDMGnE+sslA+xa25PWK1LH42lGH9uXCID985Uls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713491043; c=relaxed/simple; bh=NkfquWLKcqgyXGSpH2trZEw0PJiJQkBeWZ1fWYqOf54=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=WgsZklFe/kgfcofbFNB+ESArznP9mIEoEojA7NGZHzdOMGEfGYB0IQEdvORsBcDnD5hYNI7SbhTd9Rm5jWwPh6UopvOwpEE7TS8rAiopUXrqcX/4YeXK3ZqjprCbllP6go6HyzD+8jDJuK7g6PVzMQSN/XZgqQz7iESuxwA2RFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 43J1hswhF876899, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 43J1hswhF876899 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Apr 2024 09:43:54 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 09:43:54 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 09:43:53 +0800 From: Ping-Ke Shih To: Bitterblue Smith , "linux-wireless@vger.kernel.org" CC: Jes Sorensen , Ping-Ke Shih Subject: Re: [PATCH v2] wifi: rtl8xxxu: Fix the TX power of RTL8192CU, RTL8723AU In-Reply-To: <6ae5945b-644e-45e4-a78f-4c7d9c987910@gmail.com> References: <6ae5945b-644e-45e4-a78f-4c7d9c987910@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: <5fb760ee-fd98-422e-b670-8e6a1060a5c0@RTEXMBS04.realtek.com.tw> Date: Fri, 19 Apr 2024 09:43:53 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Bitterblue Smith wrote: > Don't subtract 1 from the power index. This was added in commit > 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts") > for unknown reasons. The vendor drivers don't do this. > > Also correct the calculations of values written to > REG_OFDM0_X{C,D}_TX_IQ_IMBALANCE. According to the vendor driver, > these are used for TX power training. > > With these changes rtl8xxxu sets the TX power of RTL8192CU the same > as the vendor driver. > > None of this appears to have any effect on my RTL8192CU device. > > Cc: stable@vger.kernel.org > Signed-off-by: Bitterblue Smith > Reviewed-by: Ping-Ke Shih 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 08b5d052d17a wifi: rtl8xxxu: Fix the TX power of RTL8192CU, RTL8723AU --- https://github.com/pkshih/rtw.git