Received-SPF: pass (google.com: domain of linux-wireless+bounces-6564-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <be016fbf-0198-4fe1-84f8-cfb0bf00dc4b@quicinc.com>
Date: Fri, 19 Apr 2024 17:39:32 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
To: <ath12k@lists.infradead.org>, Kalle Valo <kvalo@kernel.org>,
        Jeff Johnson
	<quic_jjohnson@quicinc.com>
References: <91cbda07-0b93-4e0b-adaa-cd9b078a91b8@quicinc.com>
Content-Language: en-US
From: Lingbo Kong <quic_lingbok@quicinc.com>
CC: <linux-wireless@vger.kernel.org>
In-Reply-To: <91cbda07-0b93-4e0b-adaa-cd9b078a91b8@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 2024/4/19 14:30, Lingbo Kong wrote:
>  > -------- Forwarded Message --------
>  > Subject: Re: [PATCH v8 0/4] wifi: ath12k: ACPI support
>  > Date: Fri, 19 Apr 2024 07:16:07 +0300
>  > From: Kalle Valo <kvalo@kernel.org>
>  > To: Jeff Johnson <quic_jjohnson@quicinc.com>
>  > CC: ath12k@lists.infradead.org, linux-wireless@vger.kernel.org
>  >
>  > Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>  >
>  > > On 4/18/2024 9:20 AM, Kalle Valo wrote:
>  > >
>  > >> From: Kalle Valo <quic_kvalo@quicinc.com>
>  > >>
>  > >> Through reading ACPI tables, implement Time-Average-SAR(TAS), BIOS
>  > >> SAR, configuration of CCA threshold and band edge channel power
>  > functionalities.
>  > >> This is enabled only on WCN7850.
>  > >>
>  > >> TODO:
>  > >>
>  > >> * test with ACPI support in hardware (I don't have such hardware),
>  > especially
>  > >>   suspend and hibernation
>  >
>  > [...]
>  >
>  > > I can verify this doesn't crash my system, but apparently my ACPI
>  > > doesn't have the underlying settings, so cannot verify actual
>  > > functionality
>  >
>  > Thanks for testing. I hope Lingbo has a device with proper ACPI 
> settings.
>  >
> 
> yes, I'll apply these patch then test it.
> 

Hi, kalle, i've applied this patchset, set ACPI correctly, then ACPI's 
functionality is right.

>  > > Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0:
>  > > acpi_evaluate_dsm() failed Apr 18 15:13:59 qca-HP-ZBook-14-G2 kernel:
>  > > ath12k_pci 0000:03:00.0: failed to get ACPI DSM data: -2 Apr 18
>  > > 15:13:59 qca-HP-ZBook-14-G2 kernel: ath12k_pci 0000:03:00.0: acpi
>  > > failed: -2
>  >
>  > I just want to verify that these are debug messages, right? Normal users
>  > shouldn't see any ACPI errors if there are no ACPI settings in the 
> system.
>  >
> 
> Let me check it.
> 
> Best regards
> Lingbo Kong
> 

These messages belong to debug messages, normal users won't see any ACPI 
errors if there are no ACPI settings in the system.

>  > --
>  > https://patchwork.kernel.org/project/linux-wireless/list/
>  >
>  > 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat
>  > ches
>