Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp1973022lqt; Sun, 21 Apr 2024 18:26:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTvLDVgQ+qKyCI6GEiX8o34iHnvxe4NBP2OCnwYF6F8xiMQR7s6m7RonDzxzvYJPlzZXimV/ywE7r/+xjra38Z+IwdJPC0x9+LW5tSXg== X-Google-Smtp-Source: AGHT+IHnGcemhPxMswp92TAGZfZz8p4XxZ3gXeJGXopDJUusU0q9hRpMrbfw47BXpmyWBx1MHNbm X-Received: by 2002:a05:690c:6087:b0:618:2381:2404 with SMTP id hg7-20020a05690c608700b0061823812404mr11661089ywb.44.1713749171981; Sun, 21 Apr 2024 18:26:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713749171; cv=pass; d=google.com; s=arc-20160816; b=fmC0/X4WotF+0cIz+d5FJTXeJgu2lPfx5/MKB/EI/lAjRzoRJjbVe8sqzr+nzPLB6l 7hwi3EPk6ZZLt9UUra4R7WYl58Lufglj+9wAXa1VQXBRaKmZwrrSXVOyTfy/5M9PQM2M YGFABVOh13A55DjjQCk0lBoeCBacGa6WJJcRSb2JBE1bVkVp4h6XqZJAzgNakGdPZtpJ GrXnpH860FZ0v2AkmlImNwNqhDB4/bSESQez/V+hPabq+PdbvJ4Q6O+dNdfplHRX7pcr 9UNSP+0jbPjViuiNuzH13c/Ff+eepvruydq+G6+aReV7Rk7txqaEFm47HHows37kDNPP m29Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:cc:to:from; bh=5uaPFcJBAy/5z/3OO06R02XmbRQcf679KqzEanzLDh4=; fh=lCeYhTsHebQVymYhE9ECKg2yk4kOqXBDfwpd9qqym+w=; b=BtzJBzbHKr39z80+VGFDN870wUeRp8Cn78A8ccjmINmHP74Yti5JUG/RhAmZlmbS2c dyH97MhxZFbly3n4JRFUjHo3uMobGaf8eY1wdqb5kGn/946m1/BrDjYjLgPESwWinjLP HLBozUyiVw8rQErn4oX+WOjjWWbZnANECF7JMhtZXD7MVB0gF5sjdyI65TyzHkIEff1j sk4Wc3fvgp6zqTqek+rKiH40r0+UgACHurFktGz+2eNiE8+xbh9LYjUzgL55e8EHbwoJ 0Iu49B752md9lEwqoo6aFUvCfbBNqlJ917H057t/HjZpaaFT2tb9F2WwOaeyxrcI1WUx zYOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-6607-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6607-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x9-20020a05622a000900b00439a184d5eesi2034806qtw.74.2024.04.21.18.26.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 18:26:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6607-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-6607-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6607-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F0881C20850 for ; Mon, 22 Apr 2024 01:26:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 38550ED9; Mon, 22 Apr 2024 01:26:09 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CA971391 for ; Mon, 22 Apr 2024 01:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713749169; cv=none; b=ICh01lpBTaZ95nkM9+2kXSf1bpzeurgcLfe0amTH+csOubst/FHAcl1qb+xCU+S7IE1X4UIVlXJyCQK6ZRQ66JoH2LyLGk1zUdr3D3Tma0491jMDzhdRKIWtsDbGXmG0cqkf1CS/vGEA9NR6W0vZJHrgjdqHwYmZQaLtxqWa0xQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713749169; c=relaxed/simple; bh=s+dAu+iMBIJUX70IGqVUYRnKDHEG5Kr4h+OK/P5gpNQ=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=OQoEJFY1s+qo9fj9EbdnLc5Ujn6Ca0M25WoLj2VQvj6yWJmLANiJpyG3QDatnsr4GMhJ4ajvEj+i0nFaV04zFeAsbVPdFvkFiTpaiaXd5DWmA53c0Qk71r/PO4/xsSIGX7+NjkjNMLhRE4yUwjRrLuBoKdnEi5GCLNwk9jJCtdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 43M1Q1BL03693001, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 43M1Q1BL03693001 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Apr 2024 09:26:01 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Apr 2024 09:26:01 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Apr 2024 09:26:01 +0800 From: Ping-Ke Shih To: Bitterblue Smith , "linux-wireless@vger.kernel.org" CC: Jes Sorensen , Ping-Ke Shih Subject: Re: [PATCH v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU In-Reply-To: <2e3b0b74-8bfc-4ff3-8a0c-ba1bbfa4d535@gmail.com> References: <2e3b0b74-8bfc-4ff3-8a0c-ba1bbfa4d535@gmail.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: <3b219f4b-edd0-4bd8-91f0-826265b939c2@RTEXMBS04.realtek.com.tw> Date: Mon, 22 Apr 2024 09:26:01 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Bitterblue Smith wrote: > Software control (on/off) and hardware control (automatic blinking) > tested with EDUP EP-N8568. > > Signed-off-by: Bitterblue Smith Still warns: WARNING: Missing a blank line after declarations #28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711: + u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2); + ledcfg &= LEDCFG2_DPDT_SELECT; Set patchset state to Changes Requested [v3] wifi: rtl8xxxu: Add LED control code for RTL8723BU --- https://github.com/pkshih/rtw.git