Received: by 2002:ab2:6203:0:b0:1f5:f2ab:c469 with SMTP id o3csp2051240lqt; Sun, 21 Apr 2024 22:50:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUyOHunJ02lk19xfyGUmyj22qyCYHrsLM9LXanLrHeeL/CJj72jLJam5nzm4oJUCw877x9L8zMJXSOZtivgJ5+qqdzv5YE9e/GQbOqDGA== X-Google-Smtp-Source: AGHT+IHL4ipoWDYs5pSpcJDWO/v3kNKJ1pJSm7dUv5WlNb0nGgbsFBExuM8FeyizRvsk2eXpHDoB X-Received: by 2002:a17:906:2e92:b0:a52:4091:dd52 with SMTP id o18-20020a1709062e9200b00a524091dd52mr4862140eji.72.1713765044261; Sun, 21 Apr 2024 22:50:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713765044; cv=pass; d=google.com; s=arc-20160816; b=mwGeF8BhX6sdLl9IfPCD6Wg4tow5yj0glcK6y9mRCUbn03IIFblrTkOTz9IBO4mIEs ohV5IQTUeQpnupcAz7L6IUdT8I/3OIFmE9os1Vf+WBh0d8+8ZwfgbT5+DD5/dfCwV7zY KwmUTIl8bwIfZO3H2ltZk9/pdm3wxS0/wgZE0ErKQnMH2Bb6qEf8T+dzuMDEJ/EFgVvP 0opSkJnGSIaqVC5bUHo4T2y/05SaGORkR+rWXq5Wo3GnBefBds73MV8/WuJJfbFBmOuM Uq/gOvWsYcEBYC6lrkuF9W5I+cC0fYkA/96HIA+btAt7DeBkUf+DhxKWipzKtDJr3O5v dv5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=gbEIARgYdC2FJkyc7mZ73e93KYSKUIL9lR89ZCA2+nU=; fh=IEMD1XZitpLV0dxSQ/N/GF2a17ETYlJI/hAO8zZhxZs=; b=WPnAOvvGt5YJXY+3AMgAtHKHhYHCrbraLYK1+wzGZa/1CE82KkFYQAvX1DAp/47OH7 1kMvQABH8c8idr8LCrjOvjUVbDmjp8JeRFkt65WwxYRE3mJAazIiWU2qYXyuVn0w7JwS nCq23fDuHCw6fgadDOzio0SsgBSG+aZJhxMSKmFbZrFKFWnzOPJX+5HIIqFbTqtvZ8j/ rJiIOuEp4M3LYkv4r6LMJU/cN1XY3Re1oSEDKRlQ0gGlo3UAmh71d1x4S29dlSeKqYey w7G+Hz/nFYkdFQZC2K4j6V2ccfN5ZdW4w068EykEEoDUmL/OB8/wailN40tEueAuOw39 e8NA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b="QNrB/lfm"; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-wireless+bounces-6636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o27-20020a170906289b00b00a5588d6f487si3732490ejd.815.2024.04.21.22.50.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 22:50:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-6636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.alibaba.com header.s=default header.b="QNrB/lfm"; arc=pass (i=1 spf=pass spfdomain=linux.alibaba.com dkim=pass dkdomain=linux.alibaba.com dmarc=pass fromdomain=linux.alibaba.com); spf=pass (google.com: domain of linux-wireless+bounces-6636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-6636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9E75F1F21F91 for ; Mon, 22 Apr 2024 05:50:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67DB51862F; Mon, 22 Apr 2024 05:50:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="QNrB/lfm" X-Original-To: linux-wireless@vger.kernel.org Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4F918059; Mon, 22 Apr 2024 05:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.119 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713765037; cv=none; b=ZLLt4SDs7XoxniJaLNXiXx5MdyvXbl/FW7CTRp+ymde8Uz1taSu2vzbebl9BGwGYXRbsGDU3t0SThocGZoWCtNYbIo64R/ImIuf5brk3zoV4KU93l4HxC4HM38LTh22LsC9wd84TrQ+RWn8RWwettMBWKPr0N4xIoWf1MH3sd8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713765037; c=relaxed/simple; bh=wGfpoWSm6fFunl81xx0OAs77f3/yN+iTSevM4zdbNxk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RX/H3fJzcFRal7v8vLKTfYVxqEbtHJn8d1qSMJuTO13PiMz9sfqrJs+xpOPUUyllrqLWPxZoeLl0B0kS9h6+aoXwGhyIajUOyQ1lUc8neulsScY/I2Qn/SydHX6tjI4/Vq4IBb+wFfKX168Y3Z85WN7DXDSNFVYZqf0PDm+D+Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=QNrB/lfm; arc=none smtp.client-ip=115.124.30.119 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713765032; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=gbEIARgYdC2FJkyc7mZ73e93KYSKUIL9lR89ZCA2+nU=; b=QNrB/lfm7BzuZAW4tQDbHeX45/ilsBv0hNuk9rVjncZaBHFyND/0ZL4Iwvoh3+70WrMmXT5arD740jcdZAQZf6JqwWP45PEGLrPj/SJXsv8PHcYrpFY0tGJcmU2+BEwAoblAaRWa0B6xHy/Reutfr567QS+IkRNQjVla9w3NKFQ= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0W4z0UcW_1713765023; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0W4z0UcW_1713765023) by smtp.aliyun-inc.com; Mon, 22 Apr 2024 13:50:31 +0800 From: Jiapeng Chong To: pkshih@realtek.com Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] wifi: rtw89: Remove useless else Date: Mon, 22 Apr 2024 13:50:22 +0800 Message-Id: <20240422055022.33388-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The assignment of the else and if branches is the same, so the else here is redundant, so we remove it. ./drivers/net/wireless/realtek/rtw89/phy.c:6406:2-4: WARNING: possible condition with no effect (if == else). Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8812 Signed-off-by: Jiapeng Chong --- drivers/net/wireless/realtek/rtw89/phy.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wireless/realtek/rtw89/phy.c index eaa18140d1a8..ca5a098c30a4 100644 --- a/drivers/net/wireless/realtek/rtw89/phy.c +++ b/drivers/net/wireless/realtek/rtw89/phy.c @@ -6403,10 +6403,7 @@ enum rtw89_rf_path_bit rtw89_phy_get_kpath(struct rtw89_dev *rtwdev, return RF_D; case MLO_0_PLUS_2_1RF: case MLO_2_PLUS_0_1RF: - if (phy_idx == RTW89_PHY_0) - return RF_AB; - else - return RF_AB; + return RF_AB; case MLO_0_PLUS_2_2RF: case MLO_2_PLUS_0_2RF: case MLO_2_PLUS_2_2RF: -- 2.20.1.7.g153144c