Received-SPF: pass (google.com: domain of linux-wireless+bounces-6637-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC: "kvalo@kernel.org" <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: RE: [PATCH] wifi: rtw89: Remove useless else
Thread-Topic: [PATCH] wifi: rtw89: Remove useless else
Thread-Index: AQHalHkJ1VGeiWLcV0S1xT409BU1hbFzyjGQ
Date: Mon, 22 Apr 2024 06:02:14 +0000
Message-ID: <cb9af3b7db9c464b80fbde62ec57f18e@realtek.com>
References: <20240422055022.33388-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20240422055022.33388-1-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> Subject: [PATCH] wifi: rtw89: Remove useless else

Please point out the stuff like functions you are changing.=20

>=20
> The assignment of the else and if branches is the same, so the else
> here is redundant, so we remove it.
>=20
> ./drivers/net/wireless/realtek/rtw89/phy.c:6406:2-4: WARNING: possible co=
ndition with no effect (if =3D=3D
> else).
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D8812
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/wireless/realtek/rtw89/phy.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/wireless/realtek/rtw89/phy.c b/drivers/net/wirel=
ess/realtek/rtw89/phy.c
> index eaa18140d1a8..ca5a098c30a4 100644
> --- a/drivers/net/wireless/realtek/rtw89/phy.c
> +++ b/drivers/net/wireless/realtek/rtw89/phy.c
> @@ -6403,10 +6403,7 @@ enum rtw89_rf_path_bit rtw89_phy_get_kpath(struct =
rtw89_dev *rtwdev,
>                         return RF_D;
>         case MLO_0_PLUS_2_1RF:
>         case MLO_2_PLUS_0_1RF:
> -               if (phy_idx =3D=3D RTW89_PHY_0)
> -                       return RF_AB;
> -               else
> -                       return RF_AB;
> +               return RF_AB;

The PHY configures to corresponding MLO modes are complicated, so RF people
always add branches of phy_idx to prevent missing something, and this is
intentionally to say two cases are identical. It is fine to apply your patc=
h,
but please add a comment to note that, like

/* for both PHY 0/1 */

>         case MLO_0_PLUS_2_2RF:
>         case MLO_2_PLUS_0_2RF:
>         case MLO_2_PLUS_2_2RF:
> --
> 2.20.1.7.g153144c
>=20